Update snap skill - #85047
Merged
Merged
Conversation
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the snap skill documentation to better reflect current snap workflows, especially around SDK servicing branches, subscription-driven SDK destination mapping, and post-snap operational steps.
Changes:
- Refines snap branch-cascade guidance, including preserving old stable content via a
release/<sdk-band>servicing branch when needed. - Adds a subscription-topology step to determine actual SDK destinations instead of inferring them solely from default channels.
- Expands execution guidance with reachability checks, milestone assignment based on git ancestry, and a manual InfraSwat dashboard update checkpoint.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.github/skills/snap/SKILL.md:164
- The schedule-discovery instructions reference
project_search/code_readmethods that aren’t defined anywhere else in this repo’s skill set, so an agent following this will likely get stuck. Consider rewriting this section to be tool-agnostic (DevDiv wiki page + fallback to asking the user for a link/text) rather than naming specific, undefined MCP methods.
Use an MCP server to find the schedule:
1. Search the `DevDiv.wiki` repository in organization/project `devdiv/DevDiv` for `Dev{version} Schedule` with `project_search` method `wiki`.
2. Read the returned page path with `code_read` method `content`.
3. For the snapped version, extract:
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Suppressed comments (2)
Previously missed (1) — in code that hasn't changed since the last review.
.github/skills/snap/SKILL.md:618
az repos pr createoptions are version-sensitive; passing boolean flags like--draft false --auto-complete true --squash truecan fail or be ignored depending on Azure CLI/devops extension versions (and the script already has a verification/update block to enforce state). To make the skill more robust, create the PR with only required arguments, then rely on the subsequentaz repos pr show/updateblock to set draft/autocomplete/squash.
$description = "Updates default channels for the {newVsVersion} snap. Auto-generated by snap skill."
az repos pr create --repository maestro-configuration --org https://dev.azure.com/dnceng --project internal --source-branch {cfgBranch} --target-branch production --title "Snap: update default channels for {repos} ({newVsVersion})" --description $description --draft false --auto-complete true --squash true -o none
.github/skills/snap/SKILL.md:163
- The schedule lookup references MCP methods (
project_searchwithwikiandcode_readwithcontent) that aren’t defined elsewhere in this repo’s skills/docs, so it’s unclear what tool/environment this is targeting. Make this step tool-agnostic and include an explicit fallback (e.g., ask the user for a schedule link) so the skill remains usable when that MCP integration isn’t available.
Use an MCP server to find the schedule:
1. Search the `DevDiv.wiki` repository in organization/project `devdiv/DevDiv` for `Dev{version} Schedule` with `project_search` method `wiki`.
2. Read the returned page path with `code_read` method `content`.
dibarbet
approved these changes
Aug 26, 2026
akhera99
approved these changes
Aug 26, 2026
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow