Fail when test results cannot be published - #85034
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens Azure Pipelines behavior in Roslyn’s shared log/test publishing template so that failures to publish test results are treated as task failures (rather than warnings), improving signal when the test-results service rejects uploads.
Changes:
- Configure the
PublishTestResults@2xUnit publishing step to fail if Azure Pipelines cannot publish all test results.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/publish-logs.yml | Makes xUnit test-result publication failures fail the publishing task via failTaskOnFailureToPublishResults: true. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
333fred
reviewed
Aug 25, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
333fred
approved these changes
Aug 26, 2026
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This prevents runs such as 20260825.36 from showing only the test script failure when the test-results service rejects part of the upload. Log and dump publication remains unaffected because those steps use
condition: always().Validation
PublishTestResults@2supports both failure optionsgit diff --check