Add GetValueConversion extension methods for ICoalesceOperation by Copilot · Pull Request #85029 · dotnet/roslyn

Copilot · 2026-08-25T16:57:52Z

ICoalesceOperation.ValueConversion only exposes a CommonConversion, which drops the language-specific conversion details available on the C#/VB Conversion structs. IConversionOperation, ICompoundAssignmentOperation, and ISpreadOperation already have language-specific accessors; ICoalesceOperation did not.

ICoalesceOperation c = ...;
if (c.GetValueConversion().IsBoxing) ...;

Changes

CSharpExtensions.GetValueConversion(this ICoalesceOperation) — returns Microsoft.CodeAnalysis.CSharp.Conversion from the operation's ValueConversionConvertible; throws ArgumentNullException on null and ArgumentException when the operation did not come from C# code, matching GetInConversion/GetElementConversion.
VisualBasicExtensions.GetValueConversion(coalesceExpression As ICoalesceOperation) — VB counterpart with the same shape.
Resources — new ICoalesceOperationIsNotCSharpCoalesceOperation / ICoalesceOperationIsNotVisualBasicCoalesceOperation strings, with .xlf files regenerated via UpdateXlf.
Public API — entries added to both PublicAPI.Unshipped.txt files.
Tests — new cases in IOperationTests_ICoalesceOperation for both languages: null argument, identity conversion, boxing/widening-numeric, user-defined conversion (C#), and calling the other language's extension method (expects ArgumentException).

Named GetValueConversion per the approved API review, aligning with the ValueConversion property it complements.

Fixes Add non-CommonConversion based APIs for ICoalesceOperation.ValueConversion #84905

azure-pipelines · 2026-08-25T16:58:03Z

Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

Co-authored-by: 333fred <2371880+333fred@users.noreply.github.com>

dotnet-policy-service · 2026-08-25T17:09:56Z

This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging.

azure-pipelines · 2026-08-25T17:16:39Z

Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

Copilot

Pull request overview

Adds language-specific GetValueConversion extension methods for ICoalesceOperation in both the C# and Visual Basic compiler layers, enabling callers to retrieve the full language Conversion struct (rather than only CommonConversion) and aligning ICoalesceOperation with existing conversion-accessor patterns on other operation kinds.

Changes:

Add GetValueConversion extension methods on CSharpExtensions and VisualBasicExtensions that return the language Conversion and throw ArgumentNullException/ArgumentException consistent with sibling APIs.
Add new resource strings (and regenerated .xlf entries) for the cross-language ArgumentException messages.
Add C#/VB unit tests covering null-argument behavior, representative conversion shapes, and cross-language extension invocation failures.

Show a summary per file

File	Description
src/Compilers/CSharp/Portable/CSharpExtensions.cs	Adds `CSharpExtensions.GetValueConversion(this ICoalesceOperation)` returning C# `Conversion` with language validation and consistent exceptions.
src/Compilers/VisualBasic/Portable/VisualBasicExtensions.vb	Adds `VisualBasicExtensions.GetValueConversion(coalesceExpression As ICoalesceOperation)` returning VB `Conversion` with language validation and consistent exceptions.
src/Compilers/CSharp/Test/IOperation/IOperation/IOperationTests_ICoalesceOperation.cs	Adds tests for null argument, identity/boxing/user-defined conversions, and calling VB extension on C# operation.
src/Compilers/VisualBasic/Test/IOperation/IOperation/IOperationTests_ICoalesceOperation.vb	Adds tests for null argument, identity/widening numeric conversions, and calling C# extension on VB operation.
src/Compilers/CSharp/Portable/CSharpResources.resx	Adds `ICoalesceOperationIsNotCSharpCoalesceOperation` resource string.
src/Compilers/VisualBasic/Portable/VBResources.resx	Adds `ICoalesceOperationIsNotVisualBasicCoalesceOperation` resource string.
src/Compilers/CSharp/Portable/PublicAPI.Unshipped.txt	Adds unshipped public API entry for C# `GetValueConversion`.
src/Compilers/VisualBasic/Portable/PublicAPI.Unshipped.txt	Adds unshipped public API entry for VB `GetValueConversion`.
src/Compilers/CSharp/Portable/xlf/CSharpResources.cs.xlf	Adds localized entry placeholder for new C# resource.
src/Compilers/CSharp/Portable/xlf/CSharpResources.de.xlf	Adds localized entry placeholder for new C# resource.
src/Compilers/CSharp/Portable/xlf/CSharpResources.es.xlf	Adds localized entry placeholder for new C# resource.
src/Compilers/CSharp/Portable/xlf/CSharpResources.fr.xlf	Adds localized entry placeholder for new C# resource.
src/Compilers/CSharp/Portable/xlf/CSharpResources.it.xlf	Adds localized entry placeholder for new C# resource.
src/Compilers/CSharp/Portable/xlf/CSharpResources.ja.xlf	Adds localized entry placeholder for new C# resource.
src/Compilers/CSharp/Portable/xlf/CSharpResources.ko.xlf	Adds localized entry placeholder for new C# resource.
src/Compilers/CSharp/Portable/xlf/CSharpResources.pl.xlf	Adds localized entry placeholder for new C# resource.
src/Compilers/CSharp/Portable/xlf/CSharpResources.pt-BR.xlf	Adds localized entry placeholder for new C# resource.
src/Compilers/CSharp/Portable/xlf/CSharpResources.ru.xlf	Adds localized entry placeholder for new C# resource.
src/Compilers/CSharp/Portable/xlf/CSharpResources.tr.xlf	Adds localized entry placeholder for new C# resource.
src/Compilers/CSharp/Portable/xlf/CSharpResources.zh-Hans.xlf	Adds localized entry placeholder for new C# resource.
src/Compilers/CSharp/Portable/xlf/CSharpResources.zh-Hant.xlf	Adds localized entry placeholder for new C# resource.
src/Compilers/VisualBasic/Portable/xlf/VBResources.cs.xlf	Adds localized entry placeholder for new VB resource.
src/Compilers/VisualBasic/Portable/xlf/VBResources.de.xlf	Adds localized entry placeholder for new VB resource.
src/Compilers/VisualBasic/Portable/xlf/VBResources.es.xlf	Adds localized entry placeholder for new VB resource.
src/Compilers/VisualBasic/Portable/xlf/VBResources.fr.xlf	Adds localized entry placeholder for new VB resource.
src/Compilers/VisualBasic/Portable/xlf/VBResources.it.xlf	Adds localized entry placeholder for new VB resource.
src/Compilers/VisualBasic/Portable/xlf/VBResources.ja.xlf	Adds localized entry placeholder for new VB resource.
src/Compilers/VisualBasic/Portable/xlf/VBResources.ko.xlf	Adds localized entry placeholder for new VB resource.
src/Compilers/VisualBasic/Portable/xlf/VBResources.pl.xlf	Adds localized entry placeholder for new VB resource.
src/Compilers/VisualBasic/Portable/xlf/VBResources.pt-BR.xlf	Adds localized entry placeholder for new VB resource.
src/Compilers/VisualBasic/Portable/xlf/VBResources.ru.xlf	Adds localized entry placeholder for new VB resource.
src/Compilers/VisualBasic/Portable/xlf/VBResources.tr.xlf	Adds localized entry placeholder for new VB resource.
src/Compilers/VisualBasic/Portable/xlf/VBResources.zh-Hans.xlf	Adds localized entry placeholder for new VB resource.
src/Compilers/VisualBasic/Portable/xlf/VBResources.zh-Hant.xlf	Adds localized entry placeholder for new VB resource.

Review details

Files reviewed: 34/34 changed files
Comments generated: 0
Review effort level: Lite

333fred · 2026-08-25T17:30:07Z

@dotnet/roslyn-compiler for reviews

333fred · 2026-08-25T18:00:38Z

@copilot execute a full build to make sure that all things are updated.

Co-authored-by: 333fred <2371880+333fred@users.noreply.github.com>

Copilot · 2026-08-25T18:18:01Z

@copilot execute a full build to make sure that all things are updated.

The full ./build.sh completed successfully (0 errors). It regenerated and I committed the Semantic Search API baselines in e0cee9a.

Copilot

Review details

Files reviewed: 36/36 changed files
Comments generated: 0 new
Review effort level: Lite

Copilot

Review details

Files reviewed: 36/36 changed files
Comments generated: 0 new
Review effort level: Lite

333fred · 2026-08-31T17:00:59Z

@RikkiGibson for a second review

333fred · 2026-09-02T20:46:24Z

@dotnet/roslyn-compiler @RikkiGibson for a second review

RikkiGibson · 2026-09-02T22:02:15Z

Taking a look

Initial plan

5dfd146

Copilot AI assigned Copilot and 333fred Aug 25, 2026

Copilot started work on behalf of 333fred August 25, 2026 16:58 View session

Copilot AI linked an issue Aug 25, 2026 that may be closed by this pull request

Add non-CommonConversion based APIs for ICoalesceOperation.ValueConversion #84905

Closed

Add GetValueConversion extension methods for ICoalesceOperation

d92d0db

Co-authored-by: 333fred <2371880+333fred@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add non-CommonConversion based APIs for ICoalesceOperation.ValueConversion~~ Add GetValueConversion extension methods for ICoalesceOperation Aug 25, 2026

dotnet-policy-service Bot added the Needs API Review Needs to be reviewed by the API review council label Aug 25, 2026

Copilot finished work on behalf of 333fred August 25, 2026 17:09

Copilot AI requested a review from 333fred August 25, 2026 17:09

333fred approved these changes Aug 25, 2026

View reviewed changes

333fred marked this pull request as ready for review August 25, 2026 17:16

333fred requested a review from a team as a code owner August 25, 2026 17:16

Copilot AI lite review requested due to automatic review settings August 25, 2026 17:16

333fred requested a review from a team as a code owner August 25, 2026 17:16

Copilot started reviewing on behalf of 333fred August 25, 2026 17:17 View session

Copilot AI reviewed Aug 25, 2026

View reviewed changes

Copilot started work on behalf of 333fred August 25, 2026 18:01 View session

Update semantic search API baselines

e0cee9a

Co-authored-by: 333fred <2371880+333fred@users.noreply.github.com>

Copilot AI review requested due to automatic review settings August 25, 2026 18:17

Copilot finished work on behalf of 333fred August 25, 2026 18:18

Copilot AI requested a review from 333fred August 25, 2026 18:18

Copilot started reviewing on behalf of 333fred August 25, 2026 18:18 View session

Copilot AI reviewed Aug 25, 2026

View reviewed changes

YuliiaKovalova mentioned this pull request Aug 26, 2026

E2E: mirror failed roslyn-CI build 1567331 YuliiaKovalova/roslyn#1

Closed

Merge branch 'main' into copilot/add-non-commonconversion-apis

e46ccec

Copilot AI review requested due to automatic review settings August 28, 2026 21:53

Copilot started reviewing on behalf of 333fred August 28, 2026 21:54 View session

Copilot AI reviewed Aug 28, 2026

View reviewed changes

jjonescz approved these changes Aug 31, 2026

View reviewed changes

RikkiGibson approved these changes Sep 2, 2026

View reviewed changes

333fred merged commit a078752 into main Sep 2, 2026
26 checks passed

dotnet-policy-service Bot added this to the Next milestone Sep 2, 2026

RikkiGibson deleted the copilot/add-non-commonconversion-apis branch September 2, 2026 23:19

This was referenced Sep 3, 2026

[main] Source code updates from dotnet/roslyn dotnet/dotnet#8994

Merged

[release/11.0.1xx] Source code updates from dotnet/roslyn dotnet/dotnet#9006

Merged

dotnet-bot mentioned this pull request Sep 4, 2026

[Automated] PRs inserted in VS build main-12203.181 #85159

Closed

dibarbet mentioned this pull request Sep 4, 2026

Update roslyn to 5.12.0-1.26453.19 dotnet/vscode-csharp#9731

Merged

Navigation Menu

Uh oh!

Add GetValueConversion extension methods for ICoalesceOperation - #85029

Add GetValueConversion extension methods for ICoalesceOperation#85029
333fred merged 4 commits into
mainfrom
copilot/add-non-commonconversion-apis

Copilot AI commented Aug 25, 2026 •

edited

Loading

Uh oh!

azure-pipelines Bot commented Aug 25, 2026

Uh oh!

dotnet-policy-service Bot commented Aug 25, 2026

Uh oh!

azure-pipelines Bot commented Aug 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

333fred commented Aug 25, 2026

Uh oh!

333fred commented Aug 25, 2026

Uh oh!

Copilot AI commented Aug 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

333fred commented Aug 31, 2026

Uh oh!

333fred commented Sep 2, 2026

Uh oh!

RikkiGibson commented Sep 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Copilot AI commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

azure-pipelines Bot commented Aug 25, 2026

Uh oh!

dotnet-policy-service Bot commented Aug 25, 2026

Uh oh!

azure-pipelines Bot commented Aug 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

333fred commented Aug 25, 2026

Uh oh!

333fred commented Aug 25, 2026

Uh oh!

Copilot AI commented Aug 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

333fred commented Aug 31, 2026

Uh oh!

333fred commented Sep 2, 2026

Uh oh!

RikkiGibson commented Sep 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Aug 25, 2026 •

edited

Loading