Better align Razor with Roslyn's misc file Uri handling - #85019
Merged
davidwengier merged 2 commits intoAug 26, 2026
Conversation
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Remote Razor’s additional-document classification so that “file paths” that are actually absolute URIs (including query/fragment) can still be recognized as Razor documents by inspecting the URI’s local path for .razor/.cshtml extensions.
Changes:
- Update
IsRazorDocumentclassification to handle additional-documentFilePathvalues that include URI query/fragment by parsing absolute URIs and checkingLocalPathextensions. - Add unit test coverage validating Razor vs non-Razor classification across plain paths and virtual-URI-like
FilePathvalues. - Document the intended handling of virtual URIs in the Razor agent instructions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Razor/src/Razor/test/Microsoft.CodeAnalysis.Remote.Razor.UnitTests/RemoteWorkspaceProviderTest.cs | Adds a theory validating IsRazorDocument/ContainsRazorDocuments for plain paths and URI-like file paths with queries. |
| src/Razor/src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/ProjectSystem/Extensions.cs | Enhances Razor-document detection to handle absolute URIs where query/fragment obscures the extension in the raw FilePath string. |
| .github/instructions/Razor.instructions.md | Documents the recommended approach for Razor document identity vs extension checks when FilePath is an absolute URI. |
chsienki
approved these changes
Aug 26, 2026
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/vscode-csharp#9353
Fixes dotnet/vscode-csharp#9464
Fixes dotnet/vscode-csharp#9678
This check assumed that a document file path is just a file path, but for some odd Uris Roslyn will set the document file path to the raw Uri from the incoming request, which failed.
Microsoft Reviewers: Open in CodeFlow