Revert "Allow for better parallelization with brokered services" - #85014
Merged
Conversation
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts a prior change in Roslyn’s remote brokered service JSON-RPC connection setup that disabled the default (non-concurrent) synchronization context, restoring the previous sequential-processing behavior for incoming RPC calls.
Changes:
- Removes the override that sets
jsonRpc.SynchronizationContext = nullin the remote service connection setup. - Restores default JSON-RPC synchronization-context behavior (as provided by the base
ServiceJsonRpcDescriptorimplementation).
Show a summary per file
| File | Description |
|---|---|
| src/Workspaces/Remote/Core/ServiceDescriptor.cs | Reverts the JSON-RPC synchronization-context override to restore the prior request scheduling behavior. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
dibarbet
approved these changes
Aug 24, 2026
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #82733. This still seemed to cause perf regressions, even though the runs from the PR validation were fine.
Microsoft Reviewers: Open in CodeFlow