Update dependency versions - #84952
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bd4ef3d1-3635-4dcb-8f10-d125f3fe3147
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
| <PackageVersion Include="Microsoft.VisualStudio.Utilities" Version="18.9.918" /> | ||
| <PackageVersion Include="Microsoft.VisualStudio.Utilities.Internal" Version="16.3.90" /> | ||
| <PackageVersion Include="Nerdbank.Streams" Version="2.13.16" /> | ||
| <PackageVersion Include="Nerdbank.MessagePack" Version="1.2.34" /> |
There was a problem hiding this comment.
Note: this comes from Microsoft.VisualStudio.Composition, which isn't updated until 18.9.39. VS 18.9.1 does not ship with 18.9.39 of that package, so I opted for a transitive pin instead, as VS itself appears to do.
There was a problem hiding this comment.
Consider adding a comment next to the entry to make that clear. Ideally nuget would help us highlight transitive only pins which could then later be removed again.
|
/pr-val |
|
View PR Validation Run triggered by @333fred Parameters
|
There was a problem hiding this comment.
Pull request overview
This PR updates centrally managed dependency versions to address audit warnings for packages used in the repo (but not directly shipped), aligning several .NET runtime/ASP.NET Core package pins and bumping a few specific library versions.
Changes:
- Bump
MessagePackto3.1.7for the Replay tool and MSBuild task unit tests (viaVersionOverride). - Update VS app-local runtime package version properties from
10.0.1to10.0.11and bumpNuGet.ProjectModelto6.14.3. - Update Razor’s pinned
Microsoft.AspNetCore.App.Refand runtime packages from10.0.1to10.0.11and add a central pin forNerdbank.MessagePack.
Show a summary per file
| File | Description |
|---|---|
| src/Tools/Replay/Replay.csproj | Updates MessagePack override version used by the Replay tool. |
| src/Razor/Directory.Packages.props | Updates Razor’s pinned ASP.NET Core reference/runtime package versions. |
| src/Compilers/Core/MSBuildTaskTests/Microsoft.Build.Tasks.CodeAnalysis.UnitTests.csproj | Updates MessagePack override version used by MSBuild task unit tests. |
| eng/Packages.props | Updates VS runtime package version properties, bumps NuGet.ProjectModel, and adds a transitive pin for Nerdbank.MessagePack. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
| <PackageReference Include="Microsoft.Build.Tasks.Core" /> | ||
| <PackageReference Include="Basic.CompilerLog.Util" /> | ||
| <PackageReference Include="MessagePack" VersionOverride="3.1.4" /> | ||
| <PackageReference Include="MessagePack" VersionOverride="3.1.7" /> |
There was a problem hiding this comment.
Why do we have a VersionOverride here?
There was a problem hiding this comment.
Packages.props has <PackageVersion Include="MessagePack" Version="2.5.302" /> which seems to get updated as part of the VS SDK updates
There was a problem hiding this comment.
And Basic.CompilerLog.Util comes with 3.1.4.
|
/pr-val |
|
View PR Validation Run triggered by @333fred Parameters
|
|
/pr-val |
|
View PR Validation Run triggered by @333fred Parameters
|
|
/pr-val |
|
View PR Validation Run triggered by @333fred Parameters
|
|
/pr-val |
|
View PR Validation Run triggered by @333fred Parameters
|
|
Temporary exception for the methods jitted regressions in the insertion was approved, merging. |
Addresses audit warnings for various packages that we depend on but don't directly ship. Unresolved are the sqlite warnings, which are being worked on separately.
Addresses most of #84885, except for the sqlite warnings.
Microsoft Reviewers: Open in CodeFlow