Conversation
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: JoeRobich <611219+JoeRobich@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement commit 6 package payload work for upgrade validation
Add deterministic Release integration NuGet upgrade payload staging for legacy packages.config validation
Aug 14, 2026
Co-authored-by: JoeRobich <611219+JoeRobich@users.noreply.github.com>
…ct generation Co-authored-by: JoeRobich <611219+JoeRobich@users.noreply.github.com>
JoeRobich
reviewed
Aug 14, 2026
JoeRobich
reviewed
Aug 14, 2026
JoeRobich
reviewed
Aug 14, 2026
JoeRobich
reviewed
Aug 14, 2026
Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
Co-authored-by: JoeRobich <611219+JoeRobich@users.noreply.github.com>
Co-authored-by: JoeRobich <611219+JoeRobich@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the build/payload half of the legacy
packages.configupgrade validation follow-up: produce and publish a deterministic local Roslyn package source that mirrorsroslyn-tools’ active publish set, with strict pre-test validation.Manifested source-of-truth package set
eng/config/NuGetPackageUpgradePayload.jsonwith the 21 active Roslyn package IDs.dotnet/roslyn-tools/.../NuGetPublish.cs(active entries only).Payload preparation + validation script
eng/prepare-nuget-package-upgrade-payload.ps1to:.nupkgarchives inartifacts/packages/<Configuration>/ShippingMicrosoft.Net.Compilers.Toolsetartifacts/packageValidation/<Configuration>/packagesartifacts/packageValidation/<Configuration>/package-manifest.json(ordered packages/dependencies; id/version/path/size/sha256/dependencies + deduped external deps)Release integration pipeline wiring (non-DartLab path)
eng/pipelines/build-windows-job.ymlwith an opt-inbuildNuGetUpgradePayloadpath that runs pack, runs the new preparation script, and publishes a separate artifact.eng/pipelines/test-integration-helix.ymlto enable that path only forRelease.Roslyn_NuGet_Packages_Release.Focused validator coverage
eng/tests/prepare-nuget-package-upgrade-payload.tests.ps1covering required failure modes:Example output contract produced by the script:
{ "candidateVersion": "x.y.z", "packages": [ { "id": "Microsoft.CodeAnalysis", "version": "x.y.z", "path": "packages/Microsoft.CodeAnalysis.x.y.z.nupkg", "size": 12345, "sha256": "<hash>", "dependencies": [ { "id": "Microsoft.CodeAnalysis.Common", "versionRange": "[x.y.z]", "targetFramework": "" } ] } ], "externalDependencies": [ { "id": "Newtonsoft.Json", "versionRange": "[13.0.3]", "targetFramework": "" } ] }