Fix empty localization stage on non-main/release branches in official pipeline - #84845
Merged
Conversation
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: JoeRobich <611219+JoeRobich@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code based on review comment
Fix empty localization stage on non-main/release branches in official pipeline
Aug 11, 2026
JoeRobich
marked this pull request as ready for review
August 11, 2026 06:23
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
JoeRobich
approved these changes
Aug 11, 2026
JoeRobich
left a comment
Member
There was a problem hiding this comment.
I hit merge too soon on the previous one
JoeRobich
enabled auto-merge (squash)
August 11, 2026 06:24
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an Azure Pipelines YAML limitation where the localization stage could compile to an empty stage (zero jobs) on non-main/non-release/* branches, which Azure Pipelines doesn’t support and can also create unintended stage dependency behavior for subsequent stages.
Changes:
- Wrap the entire
localizationstage in the existing${{ if ... }}compile-time condition instead of guarding only the stage’s lone job. - Ensure the stage is fully omitted on branches where localization shouldn’t run, avoiding “empty stage” compilation.
Show a summary per file
| File | Description |
|---|---|
| azure-pipelines-official.yml | Moves the compile-time branch guard to wrap the whole localization stage so it’s omitted (not empty) on non-main/non-release/* branches. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
JoeRobich
reviewed
Aug 11, 2026
davidwengier
approved these changes
Aug 11, 2026
Contributor
There was a problem hiding this comment.
Review details
Suppressed comments (1)
azure-pipelines-official.yml:163
dependsOn: []removes the default dependency of thebuildstage on prior stages (includinglocalizationonmain/release/*). This is a behavioral change beyond moving the compile-time condition; if the intent is only to avoid an emptylocalizationstage on other branches, this line should be removed (or the PR description updated to call out the parallelization change explicitly).
displayName: Build and Test
dependsOn: []
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Aug 11, 2026
…-15-langver * upstream/main: Unsafe evolution: allow await in unsafe context (dotnet#84616) Fix empty localization stage on non-main/release branches in official pipeline (dotnet#84845) Reorder stages for localization and build (dotnet#84841) Revert the sonic decl/impl split merge from main (dotnet#84831) AI Workflow - switch to use personal token instead of organizational (dotnet#84832) [main] Update dependencies from dotnet/arcade (dotnet#84819) Do not offer introduce parameter for incomplete calls (dotnet#84769)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
localizationstage inazure-pipelines-official.ymlonly guarded its single job with a compile-time condition, so on branches likecommunity,main-vs-deps,demos/*, andfeatures/*the stage would compile with zero jobs — which Azure Pipelines doesn't support, and would leavebuildimplicitly depending on a skipped/empty stage.Changes
${{ if ... }}compile-time condition from the single job insidelocalizationto wrap the entire stage, so the stage is omitted entirely on branches where it has no applicable job.