Repository navigation
Add opt-in ~/ asset-path expansion for Razor components (compiler) #84796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2,344
−4
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c8e0b06
Add asset-path metadata types for Razor tilde expansion
chsienki 2123bd7
Discover [AssetPath] and [AcceptsAssetPath] opt-in declarations
chsienki b34ecb3
Expand opted-in ~/ literals via ComponentTildePathPass
chsienki 2e45d96
Add tests and baselines for tilde path expansion
chsienki d0f1c32
Document tilde path expansion
chsienki 38e5502
Address review feedback on tilde asset-path expansion
chsienki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
35 changes: 35 additions & 0 deletions
35
...mpiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Components/AssetPathMetadata.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using Microsoft.AspNetCore.Razor.Utilities; | ||
|
|
||
| namespace Microsoft.AspNetCore.Razor.Language.Components; | ||
|
|
||
| // Descriptor-level metadata that records a single element/attribute pair for which the runtime | ||
| // has opted into '~/' asset-path expansion via [AcceptsAssetPath(element, attribute)]. | ||
| public sealed record AssetPathMetadata() : MetadataObject(MetadataKind.AssetPath) | ||
| { | ||
| public required string Element { get; init; } | ||
| public required string Attribute { get; init; } | ||
|
|
||
| internal override bool HasDefaultValue => false; | ||
|
|
||
| private protected override void BuildChecksum(in Checksum.Builder builder) | ||
| { | ||
| builder.Append(Element); | ||
| builder.Append(Attribute); | ||
| } | ||
|
|
||
| public ref struct Builder | ||
| { | ||
| public string? Element { get; set; } | ||
| public string? Attribute { get; set; } | ||
|
|
||
| public readonly AssetPathMetadata Build() | ||
| => new() | ||
| { | ||
| Element = Element.AssumeNotNull(), | ||
| Attribute = Attribute.AssumeNotNull(), | ||
| }; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.