Update pr validation inputs - #84742
Merged
Merged
Conversation
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the PR validation GitHub Actions workflow to make github-script steps more robust by passing dynamic values through environment variables instead of interpolating workflow expressions directly into JavaScript source, and adds a guard to block PR source branches with certain characters.
Changes:
- Pass step outputs into
actions/github-scriptviaenvand read them withprocess.env(avoids expression interpolation inside JS). - Add validation that fails early if the PR source branch name contains a small set of disallowed characters.
- Refactor the “Comment pipeline link” step to use env-provided parameters rather than embedding workflow expressions in the comment body.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/pr-validation.yml | Uses env vars for github-script inputs and adds a branch-name character check before proceeding. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
jjonescz
approved these changes
Aug 4, 2026
JoeRobich
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow