Skip to content

Generate Documentation - incorrect buffer bug #84709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akhera99 merged 2 commits into from
Jul 31, 2026
+3 −3
Merged

Generate Documentation - incorrect buffer bug #84709

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f5b0e0
Potential fix for pull request finding
akhera99 Jul 30, 2026
bb8d924
remove unused param
akhera99 Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/EditorFeatures/Core/DocumentationComments/CopilotGenerateDocumentationCommentManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ private async Task ShowGenerateDocumentationPromptAsync(Document document,
_inlinePromptService!.Show(
textView,
caret,
onAcceptAsync: dismissToken => GenerateAndApplyDocumentationAsync(document, snippet, snapshot, textView, dismissToken),
onAcceptAsync: dismissToken => GenerateAndApplyDocumentationAsync(document, snippet, snapshot, dismissToken),
new InlinePromptOptions
{
ProviderName = GenerateDocumentationProviderName,
Expand All @@ -81,7 +81,7 @@ private async Task ShowGenerateDocumentationPromptAsync(Document document,
}

private async Task GenerateAndApplyDocumentationAsync(Document document,
DocumentationCommentSnippet snippet, ITextSnapshot snapshot, ITextView textView, CancellationToken cancellationToken)
DocumentationCommentSnippet snippet, ITextSnapshot snapshot, CancellationToken cancellationToken)
{
// Re-check Copilot availability / file-exclusion at accept time; degrade quietly otherwise.
var copilotService = await IsGenerateDocumentationAvailableAsync(document, snippet.MemberNode, cancellationToken).ConfigureAwait(false);
Expand All @@ -107,7 +107,7 @@ private async Task GenerateAndApplyDocumentationAsync(Document document,
// Apply the edit fire-and-forget: returning tears the session down (cancelling the token), so the write
// must run afterward and not flow that token.
var token = _asyncListener.BeginAsyncOperation(nameof(ApplyDocumentationEditsAsync));
_ = ApplyDocumentationEditsAsync(textView.TextBuffer, snapshot, edits).CompletesAsyncOperation(token);
_ = ApplyDocumentationEditsAsync(snapshot.TextBuffer, snapshot, edits).CompletesAsyncOperation(token);
Comment thread
akhera99 marked this conversation as resolved.
}

private async Task ApplyDocumentationEditsAsync(ITextBuffer buffer, ITextSnapshot snapshot, ImmutableArray<DocumentationCommentEdit> edits)
Expand Down
Loading