Repository navigation
Migrate Csc to multithreaded MSBuild execution #84701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+964
−290
Merged
Changes from 14 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
0bae975
Bump Microsoft.Build to 18.7.1 and align System.* band to 10.0.8
JanProvaznik c5509d6
Mark ShowMessageForImplicitlySkipAnalyzers multithreadable; fix test …
JanProvaznik f39df64
migrate csc
OvesN b64e6b3
Remove redundant server environment clear
OvesN 3ad846e
Merge branch 'main' into dev/veronikao/migrate-csc
OvesN 0255db0
Require callers to explicitly provide environment lookup for runtime …
OvesN fb98f60
Pass explicit environment snapshots into BuildServerConnection instea…
OvesN ec9fe01
Merge branch 'main' of https://github.com/dotnet/roslyn into dev/vero…
OvesN c175fa7
Clean up, revert unnecessary changes
OvesN b941367
formatting
OvesN a15813d
Use BannedSymbols
jaredpar fab0b1c
fixes
jaredpar c533da2
fixes
jaredpar f3288fb
fixes
jaredpar bd3f2d0
new sdk
jaredpar 1a92c26
Merge remote-tracking branch 'origin/features/msbuildmt' into fix-csc…
jaredpar 9448129
fixes
jaredpar e47dd8c
new sdk version
jaredpar da0fc32
fixes
jaredpar 80d8ad3
Merge origin/main into fix-csc-task
jaredpar 5258959
PR feedback
jaredpar e2033b5
Pr feedback
jaredpar d282f14
more
jaredpar fa0cf21
more
jaredpar 3ba8a2f
build error
jaredpar 7b28515
Apply suggestion from @jjonescz
jaredpar dab569d
pr feedback
jaredpar 2f7cafc
Fix MSBuild task path tests
jaredpar 5fac7bd
Document multithreaded MSBuild task helpers
jaredpar 52b773a
pr feedback
jaredpar 305eb0c
Merge remote-tracking branch 'jaredpar/fix-csc-task' into fix-csc-task
jaredpar d29f6d5
pr feedback
jaredpar 58b9fc3
Apply suggestion from @jaredpar
jaredpar 6e0c557
fix
jaredpar f8ddfd6
fixes
jaredpar fd30eaf
more
jaredpar 775c916
pr feedback
jaredpar 259bfda
Move to interface instead of conditional code
jaredpar 6e50163
PR Feedback
jaredpar ce86426
Fix empty temp path handling
jaredpar 627bbdc
PR feedback
jaredpar 3b1378e
more
jaredpar 9feef99
more
jaredpar cb14d46
more
jaredpar 77108f1
more
jaredpar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jaredpar marked this conversation as resolved.
Resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| P:System.Environment.CurrentDirectory | ||
| M:System.Environment.GetEnvironmentVariable(System.String); | ||
| M:System.Environment.GetEnvironmentVariables(); | ||
| M:System.Environment.GetCommandLineArgs(); | ||
| M:System.Environment.GetFolderPath(); | ||
| M:System.Environment.GetLogicalDrives(); | ||
| M:System.Environment.SetEnvironmentVariable(); | ||
| M:System.IO.Directory.GetCurrentDirectory(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.IO; | ||
| using Microsoft.Build.Framework; | ||
| using Roslyn.Utilities; | ||
| namespace Microsoft.CodeAnalysis.CommandLine; | ||
|
|
||
| internal static class Extensions | ||
| { | ||
| extension(TaskEnvironment taskEnvironment) | ||
| { | ||
| internal string GetFullPath(string path) | ||
| { | ||
| var fullPath = taskEnvironment.GetAbsolutePath(path).Value; | ||
| return Path.GetFullPath(fullPath); | ||
|
jaredpar marked this conversation as resolved.
Resolved
|
||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we set
/p:RoslynEnforceCodeStyle=truetoo?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just following the other patterns in this file. Got to be honest ... I'm surprised that these are separate settings. I would assume that enabling analyzers turned on code style enforcement. Is that not the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why is that but I think they are separate. Our CI checks set both:
roslyn/azure-pipelines.yml
Line 585 in 9c32699