Repository navigation
Unions: enforce the same order of processing for base interfaces of a member provider interface source vs. metadata. #84664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -336,7 +336,7 @@ protected virtual ImmutableArray<NamedTypeSymbol> GetAllInterfaces() | |
| /// TypeSymbol.Interfaces as the source of edge data, which has had cycles and infinitely | ||
| /// long dependency cycles removed. Consequently, it is possible (and we do) use the | ||
| /// simplest version of Tarjan's topological sorting algorithm. | ||
| protected virtual ImmutableArray<NamedTypeSymbol> MakeAllInterfaces() | ||
| protected ImmutableArray<NamedTypeSymbol> MakeAllInterfaces() | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since we should keep TypeSymbol.cs and TypeSymbol.vb in sync per a comment near the top of the file, should we make a similar change in VB?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I assume you are referring to a comment about public API surface. First, this isn't a public method. Second, C# and VB symbols are no longer public.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nevertheless, it feels like if we can make the same change on the VB side, perhaps we should? |
||
| { | ||
| var result = ArrayBuilder<NamedTypeSymbol>.GetInstance(); | ||
| var visited = new HashSet<NamedTypeSymbol>(SymbolEqualityComparer.ConsiderEverything); | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.