Escape token text in VB grammar generator - #84659
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
dotnet-policy-service
Bot
added
the
Community
Contributor
Author
|
@dotnet-policy-service agree |
333fred
approved these changes
Jul 28, 2026
Member
|
@dotnet/roslyn-compiler for a second review of a community PR. |
CyrusNajmabadi
approved these changes
Jul 28, 2026
jjonescz
approved these changes
Jul 29, 2026
Member
|
Thanks for the contribution, @JJordan0C! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84635
The Visual Basic grammar generator only escaped token text when the entire text was
\or'. As a result,\=was emitted as the invalid ANTLR literal'\='.Escape backslashes and apostrophes in every token text before emitting a grammar literal, then regenerate
VisualBasic.Grammar.g4. Existing escaped token output remains unchanged, whileIntegerDivideEqualsTokenis now emitted as'\\='.Validation:
Compilers.slnfin Debug configuration (0 warnings, 0 errors).eng/generate-compiler-code.cs -test.error(156)is removed; the three pre-existing duplicate-rule diagnostics tracked by VisualBasic.Grammar.g4: three rules defined twice (structure vs. node-kind name collision in GrammarGenerator) #84633 remain.Microsoft Reviewers: Open in CodeFlow