Report LSP daemon lifecycle telemetry - #84652
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8c31ec18-3f1a-4ff5-9371-16432a7799e9
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Roslyn internal telemetry hooks for the VS Code LSP daemon lifecycle, enabling event reporting when the daemon mode is entered and when daemon clients connect/disconnect.
Changes:
- Add new
FunctionIdentries for VS Code LSP daemon start/connection/disconnection events. - Emit
Microsoft.CodeAnalysis.Internal.Log.Logger.Log(...)telemetry events when the daemon is created, when a client connection is accepted, and when that client connection is disposed.
Show a summary per file
| File | Description |
|---|---|
| src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Log/FunctionId.cs | Adds new FunctionId values (863–865) for daemon lifecycle telemetry. |
| src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/LanguageServer/NamedPipeDaemonConnectionSource.cs | Logs daemon start and per-client connect/disconnect lifecycle events via Roslyn’s internal logging/telemetry pipeline. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
JoeRobich
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
dotnet test src\LanguageServer\Microsoft.CodeAnalysis.LanguageServer.UnitTests\Microsoft.CodeAnalysis.LanguageServer.UnitTests.csproj --filter FullyQualifiedName~LanguageServerDaemonTests --nologoMicrosoft Reviewers: Open in CodeFlow