Skip to content

Ensure we don't log errors when we are cancelling loading #84622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonmalinowski merged 1 commit into from
Jul 28, 2026
+4 −2
Merged

Ensure we don't log errors when we are cancelling loading #84622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...Server/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/LanguageServerProjectLoader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,9 @@ protected LanguageServerProjectLoader(
ReloadProjectsAsync,
ProjectToLoad.Comparer,
Listener,
CancellationToken.None); // TODO: do we need to introduce a shutdown cancellation token for this?
// We don't need a separate shutdown cancellation token here: Dispose() disposes the work queue, and that
// cancels any in-flight batch along with any work that hasn't started yet.
Comment thread
jasonmalinowski marked this conversation as resolved.
CancellationToken.None);
}

private static ImmutableDictionary<string, string> BuildAdditionalProperties(ServerConfiguration? serverConfiguration)
Expand Down Expand Up @@ -387,7 +389,7 @@ await primordial.PrimordialProjectFactory.ApplyChangeToWorkspaceAsync(

return projectRestorePath;
}
catch (Exception e)
catch (Exception e) when (!ExceptionUtilities.IsCurrentOperationBeingCancelled(e, cancellationToken)) // Cancellation is only expected when we're shutting down, in which case there's no reason to do a report.
{
// Since our LogDiagnosticsAsync helper takes DiagnosticLogItems, let's just make one for this
var message = string.Format(LanguageServerResources.Exception_thrown_0, e);
Expand Down