Revert "Revert "Update VSSDK to 18.9.496-Preview"" - #84403
Merged
Conversation
This reverts commit bc396b5.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-applies a prior VSSDK/package update (a revert-of-revert), updating the repo’s Visual Studio-related dependencies and .NET SDK version while addressing newly-triggered analyzers and a few test/runtime behavior changes that come along with the dependency move.
Changes:
- Update VS/VSSDK and related dependency versions (and adjust insertion/dependency lists accordingly).
- Add targeted warning suppressions / metadata annotations to accommodate updated VS composition/analyzer behavior.
- Update language server + test infrastructure expectations to match updated SDK/tooling behavior (global.json, run-api invocation, path canonicalization, etc.).
Reviewed changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Workspaces/Remote/Core/ProjectSystem/IWorkspaceProjectBatch.cs | Adds PolyType TypeShape metadata and makes the interface partial for shape generation. |
| src/Workspaces/Remote/Core/ProjectSystem/IWorkspaceProject.cs | Adds PolyType TypeShape metadata and makes the interface partial for shape generation. |
| src/VisualStudio/TestUtilities2/StubVsServiceExporter`2.vb | Suppresses VSMEF008 around MEF importing constructor (tracked by issue). |
| src/VisualStudio/TestUtilities2/StubVsServiceExporter`1.vb | Suppresses VSMEF008 around MEF importing constructor (tracked by issue). |
| src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/EditorInProcess.cs | Adds an assumption check to avoid null outlining manager usage. |
| src/VisualStudio/CSharp/Impl/LanguageService/CSharpOptionPageService.cs | Suppresses VSSDK008 around LoadPackage during MEF part construction (tracked by issue). |
| src/VisualStudio/Core/Def/Implementation/VisualStudioWorkspaceContextService.cs | Suppresses obsolete UIContext guid warning with tracking comment. |
| src/Setup/DevDivInsertionFiles/DevDivInsertionFiles.csproj | Removes additional dependencies from insertion dependency list. |
| src/Razor/src/Razor/test/Microsoft.VisualStudio.Razor.IntegrationTests/InProcess/EditorInProcess_Outlining.cs | Adds null-check assumption for outlining manager in Razor integration tests. |
| src/Razor/src/Razor/test/Microsoft.VisualStudio.LanguageServices.Razor.UnitTests/LspEditorFeatureDetectorTest.cs | Suppresses obsolete UIContext guid warning in unit test mock setup. |
| src/Razor/src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/LspEditorFeatureDetector.cs | Suppresses obsolete UIContext guid warning in production logic. |
| src/Razor/src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/LiveShare/Guest/RazorGuestInitializationService.cs | Suppresses VSMEF008 for MEF import contract mismatch (tracked by issue). |
| src/Razor/src/Razor/src/Microsoft.VisualStudio.LanguageServer.ContainedLanguage/MessageInterception/IInterceptMethodMetadata.cs | Adds MetadataView and makes interface partial for metadata-view/source-gen expectations. |
| src/Razor/Directory.Packages.props | Adjusts Razor subtree package versions to align with updated VS package versioning. |
| src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/FileBasedPrograms/VirtualProjectXmlProvider.cs | Adds localizeOutput parameter and threads it into DotnetCliHelper.Run. |
| src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/FileBasedPrograms/FileBasedProgramsProjectSystem.cs | Updates call site to pass localizeOutput. |
| src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer.UnitTests/VirtualProjectXmlProviderTests.cs | Updates tests for new localizeOutput parameter and SDK version in test global.json. |
| src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer.UnitTests/MiscellaneousFiles/FileBasedProgramsWorkspaceTests.cs | Updates expected generated document name for file-based program scenario. |
| src/EditorFeatures/TestUtilities/Workspaces/TestWorkspaceFixture.cs | Makes reflection-based cache clearing resilient to lazy initialization (null). |
| src/EditorFeatures/TestUtilities/EditorTestCompositions.cs | Removes previously-added test part from editor test composition. |
| src/EditorFeatures/CSharp/Microsoft.CodeAnalysis.CSharp.EditorFeatures.csproj | Adds explicit package reference needed for updated VS dependencies. |
| src/EditorFeatures/CSharp/BlockCommentEditing/BlockCommentEditingCommandHandler.cs | Updates pooled string builder usage to a using var/out-builder pattern. |
| src/EditorFeatures/Core/LanguageServer/AlwaysActivateInProcCapabilitiesProvider.cs | Suppresses VSMEF016 for metadata view source-gen requirement (tracked by issue). |
| src/EditorFeatures/Core/ExternalAccess/IntelliCode/IntentProcessor.cs | Suppresses VSMEF016 for metadata view source-gen requirement (tracked by issue). |
| src/EditorFeatures/Core/EditAndContinue/VSServiceBrokerWrapper.cs | Suppresses VSMEF008 for MEF import contract mismatch (tracked by issue). |
| src/Compilers/VisualBasic/Test/CommandLine/CommandLineTests.vb | Updates expected missing-assembly message construction. |
| src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs | Updates expected missing-assembly message construction. |
| src/Compilers/Core/MSBuildTaskTests/DotNetSdkTests.cs | Adjusts expected SourceRoot-mapped paths to match absolute canonicalization. |
| global.json | Updates SDK/toolset version to 10.0.301. |
| eng/Versions.props | Updates System.ValueTuple version. |
| eng/Version.Details.xml | Updates several dotnet/dotnet dependency versions (10.0.1 → 10.0.8). |
| eng/Version.Details.props | Updates dotnet/dotnet dependency versions and adds RoslynDiagnosticsAnalyzers version property. |
| eng/pipelines/variables-build.yml | Disables MSBuild server usage in CI with a tracking TODO. |
| eng/Packages.props | Updates many VS/VSSDK-related package versions and pins some to avoid type-forwarding collisions. |
Member
Author
Member
Author
|
/pr-val |
Contributor
|
View PR Validation Run triggered by @tmat Parameters
|
akhera99
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #84363
The issue was with Apex test harness and is being addressed by
https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/756039