[Sonic] Minor cleanup - #84181
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs minor cleanup in the Razor remote services by (1) clarifying an inline comment about which diagnostics are being queried during formatting, and (2) removing an unused helper method from the remote diagnostics helper.
Changes:
- Clarify the comment in
RazorFormattingService.GetDocumentFormattingChangesAsyncexplaining thatCSharpDocument.Diagnosticsare Razor diagnostics (not Roslyn C# diagnostics). - Remove the unused
GetRazorDiagnosticsAsyncmethod fromRazorDiagnosticHelperand drop its now-unusedSystem.Threading/System.Threading.Tasksusings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Razor/src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/Formatting/RazorFormattingService.cs | Updates an explanatory comment near the range-formatting diagnostic guard. |
| src/Razor/src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/Diagnostics/RazorDiagnosticHelper.cs | Deletes an unused async diagnostics helper method and associated usings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a couple of small things I noticed while look for uses of
GetImplCSharpDocument(). One unused method, and one comment.Microsoft Reviewers: Open in CodeFlow