[Sonic] Move edit service up to Remote and make it sonic aware - #84086
Merged
davidwengier merged 36 commits intoJun 12, 2026
Merged
[Sonic] Move edit service up to Remote and make it sonic aware#84086davidwengier merged 36 commits into
davidwengier merged 36 commits into
Conversation
May as well move this now. Can't move the rest until we do formatting
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was one simple method that was called from the Workspaces layer, but that can just be an extension method
Just happened to notice that these two were skipped, the issue they link to is closed, and they pass, so figured I'd unskip them
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
chsienki
approved these changes
Jun 11, 2026
Go to definition is a little more complex because I also moved things from Workspaces to Remote as part of it. ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/dotnet/roslyn/pull/84102)
Similar to edit service, except even bigger, and definitely big enough for its own PR. Hopefully the last of the "big" services to move that other things will depend on. Commit-at-a-time is probably the easiest, even though some of them are pretty small.
davidwengier
merged commit Jun 12, 2026
d00caf2
into
dev/dawengie/MoreMoreSonicTooling
1 check was pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a reasonable chunk of work on its own, and is pivotal to a few other things, so putting it up on its own. We can't move
IRazorEditServiceitself yet, sadly, because formatting needs to use it. Formatting is probably the next PR though.Commit at a time will probably be easiest.
Microsoft Reviewers: Open in CodeFlow