[main] Source code updates from dotnet/dotnet#81958
Merged
dotnet-maestro[bot] merged 2 commits intomainfrom Jan 12, 2026
Merged
[main] Source code updates from dotnet/dotnet#81958dotnet-maestro[bot] merged 2 commits intomainfrom
dotnet-maestro[bot] merged 2 commits intomainfrom
Conversation
[[ commit created by automation ]]
![dotnet-policy-service[bot]](https://avatars.githubusercontent.com/in/285228?s=60&v=4){kind=small}
333fred
previously requested changes
Jan 11, 2026
| </ItemGroup> | ||
| <ItemGroup Condition="'$(DotNetBuildSourceOnly)' != 'true'"> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" PrivateAssets="all" /> | ||
| <PackageReference Include="Roslyn.Diagnostics.Analyzers" PrivateAssets="all" /> |
Member
There was a problem hiding this comment.
@dotnet/product-construction can we investigate why this attempted to revert this change? The corresponding locations in the VMR's commit have not been modified in 2 years. I'm extremely concerned that if this is getting overwritten, other fixes and changes may be overridden by the code flow.
Member
There was a problem hiding this comment.
Jan moved Roslyn.Diagnostics.Analyzers out of this item group, to the unconditioned one, in #81856 but that broke the last VMR flow PR from Roslyn and so he pushed a revert commit to that PR: dotnet/dotnet#4084
Member
There was a problem hiding this comment.
Ah, so this is a rare instance of git blame kinda lying to me. Thanks.
dotnet-maestro
bot
deleted the
darc-main-51dc08c0-4113-4a50-9f96-16a4ec9fd9d8
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Updated Dependencies
Associated changes in source repos
Diff the source with this PR branch