Include Enc diagnostics in Razor requests#81941
Merged
davidwengier merged 1 commit intodotnet:mainfrom Jan 12, 2026
Merged
Conversation
davidwengier
added a commit
to dotnet/razor
that referenced
this pull request
Jan 9, 2026
…2664) Fixes #12661 (along with dotnet/roslyn#81941 that actually makes the diagnostics get reported) No tests because the existing C# tests cover everything, and there is no reasonable way to get Roslyn to create an ENC diagnostic in a test IMO.
| public static IDiagnosticSource CreateOpenDocumentSource(Document document) | ||
| => new OpenDocumentSource(document); | ||
|
|
||
| internal static Task<ImmutableArray<DiagnosticData>> GetDocumentDiagnosticsAsync(Document document, CancellationToken cancellationToken) |
Contributor
There was a problem hiding this comment.
why have this helper if you alread hve exposed GetDiagnosticsAsync(doc, ct) publicly?
Contributor
There was a problem hiding this comment.
oh. i see. there are two classes here. one nested in the other. ok.
CyrusNajmabadi
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of dotnet/razor#12661
I just missed this when I first did cohosting diagnostics.