Merged
Conversation
dibarbet
reviewed
Jan 9, 2026
src/Features/Core/Portable/ProjectContext/IProjectContextRefresher.cs
Outdated
Show resolved
Hide resolved
| LspWorkspaceRegistrationService lspWorkspaceRegistrationService, | ||
| LspWorkspaceManager lspWorkspaceManager, | ||
| IClientLanguageServerManager notificationManager) | ||
| : base(asynchronousOperationListenerProvider, lspWorkspaceRegistrationService, lspWorkspaceManager, notificationManager) |
Contributor
There was a problem hiding this comment.
nit. consider primary constructor.
CyrusNajmabadi
approved these changes
Jan 9, 2026
Contributor
CyrusNajmabadi
left a comment
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
Seems reasonable. but i'd like DAvid to take a look :)
dibarbet
approved these changes
Jan 9, 2026
JoeRobich
added a commit
to dotnet/vscode-csharp
that referenced
this pull request
Jan 12, 2026
This PR adds a project context feature which takes enables the client to use the new project context refresh support added to the LSP in dotnet/roslyn#81938. The current method of validating a project context is "up to date" is replaced with waiting to receive refresh notifications from the server. A Roslyn build with refresh support merged in #8877 Addresses #8849
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a ProjectContext refresh queue. This will allow the C# extension to know when changes occur that could affect the project context displayed for open files. Currently it sends a notification when workspace changes occur.
I believe this should address dotnet/vscode-csharp#8849