Skip to content

Comments

Remove cohosting feature flag checks and associated code#81914

Merged
davidwengier merged 4 commits intodotnet:mainfrom
davidwengier:RemoveCohostFeatureFlag
Jan 8, 2026
Merged

Remove cohosting feature flag checks and associated code#81914
davidwengier merged 4 commits intodotnet:mainfrom
davidwengier:RemoveCohostFeatureFlag

Conversation

@davidwengier
Copy link
Member

In 18.3 cohosting defaults to on, in 18.4 we're removing the feature flag, so this has to go first as it checks the feature flag.

Fixes dotnet/razor#12655
Fixes #51678

I manually tested and hot reload still works, diagnostics still get reported etc. I didn't test a rude edit, because I'm not sure what one is any more, that can be achieved in a Razor file.

@davidwengier davidwengier requested review from a team and tmat January 8, 2026 06:08
@davidwengier davidwengier requested a review from a team as a code owner January 8, 2026 06:08
@davidwengier davidwengier changed the title Remove option that exposes the feature flag Remove cohosting feature flag checks and associated code Jan 8, 2026
@jasonmalinowski
Copy link
Member

And There Was Much Rejoicing

@tmat
Copy link
Member

tmat commented Jan 8, 2026

what one is any more, that can be achieved in a Razor file.

Changing visibility would do:

@{
public class C {}
}
@{
internal class C {}
}

@davidwengier
Copy link
Member Author

Changing visibility would do:

Thanks. Looks like this is broken, but it's broken in main too so logged dotnet/razor#12661 to investigate separately

@davidwengier davidwengier enabled auto-merge January 8, 2026 21:41
@davidwengier davidwengier merged commit ee64d51 into dotnet:main Jan 8, 2026
25 of 26 checks passed
@davidwengier davidwengier deleted the RemoveCohostFeatureFlag branch January 8, 2026 22:50
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jan 8, 2026
jasonmalinowski added a commit to jasonmalinowski/roslyn that referenced this pull request Jan 16, 2026
This was used to speed up Razor runs prior to cohosting, where we would
be creating lots of forks of things. But now that
dotnet#81914 is merged, there is no
calling code.
jasonmalinowski added a commit that referenced this pull request Jan 20, 2026
This was used to speed up Razor runs prior to cohosting, where we would
be creating lots of forks of things. But now that
#81914 is merged, there is no
calling code.
@davidwengier davidwengier modified the milestones: Next, 18.4 Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the check in hot reload for compile time solution Remove workaround for Razor design-time only source-generated files

4 participants