Remove cohosting feature flag checks and associated code#81914
Merged
davidwengier merged 4 commits intodotnet:mainfrom Jan 8, 2026
Merged
Remove cohosting feature flag checks and associated code#81914davidwengier merged 4 commits intodotnet:mainfrom
davidwengier merged 4 commits intodotnet:mainfrom
Conversation
Member
dibarbet
approved these changes
Jan 8, 2026
Member
Changing visibility would do: |
tmat
reviewed
Jan 8, 2026
src/EditorFeatures/Core/EditAndContinue/ActiveStatementTrackingService.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Jan 8, 2026
src/EditorFeatures/Core/EditAndContinue/EditAndContinueLanguageService.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Jan 8, 2026
src/EditorFeatures/Core/EditAndContinue/EditAndContinueLanguageService.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Jan 8, 2026
src/EditorFeatures/Core/EditAndContinue/EditAndContinueLanguageService.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Jan 8, 2026
...uageServer/Protocol/Features/EditAndContinue/EditAndContinueDiagnosticSource_OpenDocument.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Jan 8, 2026
src/Workspaces/Remote/Core/EditAndContinue/ManagedHotReloadLanguageService.cs
Outdated
Show resolved
Hide resolved
Member
Author
Thanks. Looks like this is broken, but it's broken in main too so logged dotnet/razor#12661 to investigate separately |
tmat
approved these changes
Jan 8, 2026
jasonmalinowski
added a commit
to jasonmalinowski/roslyn
that referenced
this pull request
Jan 16, 2026
This was used to speed up Razor runs prior to cohosting, where we would be creating lots of forks of things. But now that dotnet#81914 is merged, there is no calling code.
jasonmalinowski
added a commit
that referenced
this pull request
Jan 20, 2026
This was used to speed up Razor runs prior to cohosting, where we would be creating lots of forks of things. But now that #81914 is merged, there is no calling code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

In 18.3 cohosting defaults to on, in 18.4 we're removing the feature flag, so this has to go first as it checks the feature flag.
Fixes dotnet/razor#12655
Fixes #51678
I manually tested and hot reload still works, diagnostics still get reported etc. I didn't test a rude edit, because I'm not sure what one is any more, that can be achieved in a Razor file.