Simplify LSP refresh queue management#81864
Merged
CyrusNajmabadi merged 5 commits intodotnet:mainfrom Jan 5, 2026
Merged
Conversation
CyrusNajmabadi
commented
Jan 5, 2026
| private readonly CancellationTokenSource _disposalTokenSource; | ||
| private readonly LspWorkspaceRegistrationService _lspWorkspaceRegistrationService; | ||
|
|
||
| protected bool _isQueueCreated; |
Contributor
Author
There was a problem hiding this comment.
removed this. we already have the presence/absence of the queue we can check.
CyrusNajmabadi
commented
Jan 5, 2026
| /// Enqueues a request to refresh the workspace. If <paramref name="documentUri"/> is null, then the refresh will | ||
| /// always happen. If non-null, the refresh will only happen if the client is <em>not</em> tracking that document. | ||
| /// If the client is tracking the document, no refresh is necessary as the client clearly knows about the change. | ||
| /// </summary> |
Contributor
Author
There was a problem hiding this comment.
added docs as the semantics weren't previous clear to me.
dibarbet
approved these changes
Jan 5, 2026
JoeRobich
approved these changes
Jan 5, 2026
This was referenced Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.