Move to async/await (Features) layer#81810
Merged
CyrusNajmabadi merged 2 commits intodotnet:mainfrom Dec 30, 2025
Merged
Conversation
This reverts commit f511fcb.
CyrusNajmabadi
force-pushed
the
revertAsync2
branch
from
25d68cf to
4a47b43
Compare
Contributor
Author
|
@davidwengier this also passed (though feel free to double check me in case i'm somehow misinterpreting the insertion prs). |
davidwengier
approved these changes
Dec 30, 2025
Member
davidwengier
left a comment
davidwengier
left a comment
There was a problem hiding this comment.
Indeed it did. Merging these slowly probably makes sense anyway, as now we know VS and Features layers are fine, but we'll also be able to tell if the combination of the two is good, or if the issue is somehow cumulative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making individual layer changes, and running individual insertion tests for each.
https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=13019279&view=results
PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/697526