Update methods to be async.#81737
Merged
CyrusNajmabadi merged 46 commits intodotnet:mainfrom Dec 19, 2025
Merged
Conversation
CyrusNajmabadi
force-pushed
the
runNewAsync
branch
3 times, most recently
from
574251e to
04bad0f
Compare
CyrusNajmabadi
force-pushed
the
runNewAsync
branch
from
3ce23f4 to
48e25b2
Compare
This reverts commit 471e05e.
CyrusNajmabadi
commented
Dec 18, 2025
| @@ -102,10 +102,8 @@ public async Task OpenProjectsAsync(ImmutableArray<string> projectFilePaths) | |||
| }; | |||
| } | |||
|
|
|||
| protected override ValueTask OnProjectUnloadedAsync(string projectFilePath) | |||
| protected override async ValueTask OnProjectUnloadedAsync(string projectFilePath) | |||
| { | |||
Contributor
Author
There was a problem hiding this comment.
Suggested change
| { | |
| { | |
| // Nothing else to unload for ordinary projects. |
Contributor
Author
|
No regressions found. Marking ready. |
Contributor
Author
|
@davidwengier @JoeRobich ptal :) |
JoeRobich
approved these changes
Dec 19, 2025
Member
|
Boy, I hope we had a refactoring to assist you with all that. =) |
Contributor
Author
Yup! Standard approach of using Roslyn to modify Roslyn :) |
This was referenced Dec 20, 2025
davidwengier
added a commit
that referenced
this pull request
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrote a tool for this. General rule was: Method is eligible to become async if it is manually doing Task/ValueTask construction in it somewhere.
So a non-async Task based method that just returns another Task-based method isn't affected. It's only if you're doing things like
Task.FromResult(...),new ValueTask(...)etc.Build: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=12986332&view=results
PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/696513