Skip to content

Small allocation reduction in lsp hot path #81683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ToddGrun merged 1 commit into from
Dec 14, 2025
Merged

Small allocation reduction in lsp hot path #81683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/LanguageServer/Protocol/Extensions/Extensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
using System.Threading;
using System.Threading.Tasks;
using Microsoft.CodeAnalysis.FindUsages;
using Microsoft.CodeAnalysis.PooledObjects;
using Microsoft.CodeAnalysis.QuickInfo.Presentation;
using Microsoft.CodeAnalysis.Shared.Collections;
using Microsoft.CodeAnalysis.Shared.Extensions;
Expand Down Expand Up @@ -72,11 +73,18 @@ public static ImmutableArray<TextDocument> GetTextDocuments(this Solution soluti
{
var documentIds = GetDocumentIds(solution, documentUri);

var documents = documentIds
.Select(solution.GetTextDocument)
.WhereNotNull()
.ToImmutableArray();
return documents;
if (documentIds.IsEmpty)
return [];

using var _ = ArrayBuilder<TextDocument>.GetInstance(out var documentsBuilder);

foreach (var documentId in documentIds)
{
if (solution.GetTextDocument(documentId) is { } document)
documentsBuilder.Add(document);
}

return documentsBuilder.ToImmutableAndClear();
}

public static ImmutableArray<DocumentId> GetDocumentIds(this Solution solution, DocumentUri documentUri)
Expand Down
Loading