Copy slightly less data during SourceText.computeContentHash#81682
Merged
ToddGrun merged 1 commit intodotnet:mainfrom Dec 15, 2025
Merged
Copy slightly less data during SourceText.computeContentHash#81682ToddGrun merged 1 commit intodotnet:mainfrom
ToddGrun merged 1 commit intodotnet:mainfrom
Conversation
As outlined in a comment in the code, just use ImmutableCollectionsMarshal.AsImmutableArray to make the code a bit simpler and more efficient.
CyrusNajmabadi
approved these changes
Dec 13, 2025
davidwengier
approved these changes
Dec 13, 2025
jjonescz
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As outlined in a comment in the code, just use ImmutableCollectionsMarshal.AsImmutableArray to make the code a bit simpler and more efficient.