Don't report assignment to ref extension parameter as unused#81680
Merged
jcouv merged 2 commits intodotnet:mainfrom Dec 16, 2025
Merged
Don't report assignment to ref extension parameter as unused#81680jcouv merged 2 commits intodotnet:mainfrom
jcouv merged 2 commits intodotnet:mainfrom
Conversation
Member
Author
|
@CyrusNajmabadi @dotnet/roslyn-ide for review. Thanks |
| #else | ||
| if (owningSymbol.ContainingSymbol is INamedTypeSymbol { IsExtension: true, ExtensionParameter: { } extensionParameter }) | ||
| { | ||
| return parameters.Insert(0, extensionParameter); |
Contributor
There was a problem hiding this comment.
this is fine with me. but i'm curious why this was placed in position 0. it's not obvious as to why. consider doc'ing.
Comment on lines
141
to
151
| var parameters = owningSymbol.GetParameters(); | ||
| #if ROSLYN_4_12_OR_LOWER | ||
| return parameters; | ||
| #else | ||
| if (owningSymbol.ContainingSymbol is INamedTypeSymbol { IsExtension: true, ExtensionParameter: { } extensionParameter }) | ||
| { | ||
| return parameters.Insert(0, extensionParameter); | ||
| } | ||
|
|
||
| return parameters; | ||
| #endif |
Contributor
There was a problem hiding this comment.
Suggested change
| var parameters = owningSymbol.GetParameters(); | |
| #if ROSLYN_4_12_OR_LOWER | |
| return parameters; | |
| #else | |
| if (owningSymbol.ContainingSymbol is INamedTypeSymbol { IsExtension: true, ExtensionParameter: { } extensionParameter }) | |
| { | |
| return parameters.Insert(0, extensionParameter); | |
| } | |
| return parameters; | |
| #endif | |
| var parameters = owningSymbol.GetParameters(); | |
| #if !ROSLYN_4_12_OR_LOWER | |
| if (owningSymbol.ContainingSymbol is INamedTypeSymbol { IsExtension: true, ExtensionParameter: { } extensionParameter }) | |
| { | |
| return parameters.Insert(0, extensionParameter); | |
| } | |
| #else | |
| return parameters; | |
| #endif |
CyrusNajmabadi
approved these changes
Dec 16, 2025
Contributor
CyrusNajmabadi
left a comment
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
Signing off as none of the feedback is blocking.
This was referenced Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataFlowAnalyzer.SetAnalysisDataOnMethodExithas logic to recognize assignments toref/outparameters as reachable and used, The fix is to perform the analysis considering the full set of parameters, including the extension parameter.Fixes #81554