Skip to content

Remove unnecessary lightup code #81597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CyrusNajmabadi merged 5 commits into from
Dec 9, 2025
Merged

Remove unnecessary lightup code #81597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
76a8c38
Remove unnecessary lightup code
CyrusNajmabadi Dec 9, 2025
1053760
Remove unnecessary lightup code
CyrusNajmabadi Dec 9, 2025
9b9647a
Remove unnecessary lightup code
CyrusNajmabadi Dec 9, 2025
fe5ec90
Remove unnecessary lightup code
CyrusNajmabadi Dec 9, 2025
a63ea8c
Remove unnecessary lightup code
CyrusNajmabadi Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/RoslynAnalyzers/PerformanceSensitiveAnalyzers/Core/ExplicitAllocationAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@

using System;
using System.Collections.Immutable;
using Analyzer.Utilities;
using Analyzer.Utilities.Extensions;
using Analyzer.Utilities.Lightup;
using Microsoft.CodeAnalysis.Diagnostics;
using Microsoft.CodeAnalysis.Operations;

Expand Down
3 changes: 1 addition & 2 deletions src/RoslynAnalyzers/PublicApiAnalyzers/Core/Analyzers/DeclarePublicApiAnalyzer.Impl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
using System.Threading;
using Analyzer.Utilities;
using Analyzer.Utilities.Extensions;
using Analyzer.Utilities.Lightup;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.Diagnostics;
using Microsoft.CodeAnalysis.PooledObjects;
Expand Down Expand Up @@ -1039,7 +1038,7 @@ public static bool VisitNamedTypeDeclaration(INamedTypeSymbol symbol)

private static bool CheckTypeParameterConstraints(ITypeParameterSymbol symbol)
{
if (symbol.HasReferenceTypeConstraint() &&
if (symbol.HasReferenceTypeConstraint &&
symbol.ReferenceTypeConstraintNullableAnnotation == NullableAnnotation.None)
{
// where T : class~
Expand Down
14 changes: 0 additions & 14 deletions src/RoslynAnalyzers/PublicApiAnalyzers/Core/Analyzers/ITypeParameterSymbolExtensions.cs
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions src/RoslynAnalyzers/PublicApiAnalyzers/Core/Analyzers/ITypeSymbolExtensions.cs
View file
Open in desktop

This file was deleted.

75 changes: 0 additions & 75 deletions src/RoslynAnalyzers/PublicApiAnalyzers/Core/Analyzers/NullableContext.cs
View file
Open in desktop

This file was deleted.

36 changes: 0 additions & 36 deletions src/RoslynAnalyzers/PublicApiAnalyzers/Core/Analyzers/NullableContextExtensions.cs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/RoslynAnalyzers/Roslyn.Diagnostics.Analyzers/Core/AbstractDoNotCopyValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
using System.Linq;
using Analyzer.Utilities;
using Analyzer.Utilities.Extensions;
using Analyzer.Utilities.Lightup;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.Diagnostics;
using Microsoft.CodeAnalysis.FlowAnalysis;
Expand Down
163 changes: 0 additions & 163 deletions src/RoslynAnalyzers/Utilities.UnitTests/Lightup/LightupHelpersTests.cs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/RoslynAnalyzers/Utilities/Compiler.CSharp/Analyzer.CSharp.Utilities.projitems
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,5 @@
</PropertyGroup>
<ItemGroup>
<Compile Include="$(MSBuildThisFileDirectory)Extensions\SyntaxNodeExtensions.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Lightup\SyntaxKindEx.cs" />
</ItemGroup>
</Project>
14 changes: 0 additions & 14 deletions src/RoslynAnalyzers/Utilities/Compiler.CSharp/Lightup/SyntaxKindEx.cs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/RoslynAnalyzers/Utilities/Compiler/Analyzer.Utilities.projitems
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
<Compile Include="$(MSBuildThisFileDirectory)Extensions\SourceTextExtensions.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Extensions\StringCompatExtensions.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Extensions\WellKnownDiagnosticTagsExtensions.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Lightup\LightupHelpers.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Options\MSBuildItemOptionNames.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Options\OptionKey.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Options\OptionKind.cs" />
Expand Down
1 change: 0 additions & 1 deletion src/RoslynAnalyzers/Utilities/Compiler/CodeMetrics/ComputationalComplexityMetrics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
using System;
using System.Collections.Immutable;
using System.Linq;
using Analyzer.Utilities.Lightup;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.Operations;

Expand Down
1 change: 0 additions & 1 deletion src/RoslynAnalyzers/Utilities/Compiler/CodeMetrics/MetricsHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
using System.Diagnostics;
using System.Linq;
using Analyzer.Utilities;
using Analyzer.Utilities.Lightup;
using Microsoft.CodeAnalysis.Operations;
using Microsoft.CodeAnalysis.PooledObjects;

Expand Down
2 changes: 0 additions & 2 deletions src/RoslynAnalyzers/Utilities/Compiler/Extensions/INamedTypeSymbolExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
using System;
using System.Collections.Concurrent;
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.Linq;
using Analyzer.Utilities.Lightup;
using Microsoft.CodeAnalysis;

namespace Analyzer.Utilities.Extensions
Expand Down
Loading