Skip to content

Colorization for array, pointer, and function pointer type aliases followup #81363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoeRobich merged 2 commits into from
Nov 20, 2025
Merged

Colorization for array, pointer, and function pointer type aliases followup #81363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94749b0
Add new classifications to the color theme
JoeRobich Nov 20, 2025
527422f
Define new classifications as custom tokens
JoeRobich Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/LanguageServer/Protocol/Handler/SemanticTokens/CustomLspSemanticTokenNames.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ internal sealed class CustomLspSemanticTokenNames
public const string Punctuation = "punctuation";
public const string StringVerbatim = "stringVerbatim";
public const string StringEscapeCharacter = "stringEscapeCharacter";
public const string ArrayName = "array";
public const string PointerName = "pointer";
public const string FunctionPointerName = "functionPointer";
public const string RecordClassName = "recordClass";
public const string DelegateName = "delegate";
public const string ModuleName = "module";
Expand Down Expand Up @@ -92,6 +95,9 @@ internal sealed class CustomLspSemanticTokenNames
[ClassificationTypeNames.Punctuation] = Punctuation,
[ClassificationTypeNames.VerbatimStringLiteral] = StringVerbatim,
[ClassificationTypeNames.StringEscapeCharacter] = StringEscapeCharacter,
[ClassificationTypeNames.ArrayName] = ArrayName,
[ClassificationTypeNames.PointerName] = PointerName,
[ClassificationTypeNames.FunctionPointerName] = FunctionPointerName,
[ClassificationTypeNames.RecordClassName] = RecordClassName,
[ClassificationTypeNames.DelegateName] = DelegateName,
[ClassificationTypeNames.ModuleName] = ModuleName,
Expand Down
3 changes: 0 additions & 3 deletions src/LanguageServer/Protocol/Handler/SemanticTokens/SemanticTokensSchema.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@ internal readonly struct SemanticTokensSchema
[ClassificationTypeNames.EnumMemberName] = SemanticTokenTypes.EnumMember,
[ClassificationTypeNames.EventName] = SemanticTokenTypes.Event,
[ClassificationTypeNames.PreprocessorKeyword] = SemanticTokenTypes.Macro,
[ClassificationTypeNames.ArrayName] = SemanticTokenTypes.Class,
[ClassificationTypeNames.PointerName] = SemanticTokenTypes.Struct,
[ClassificationTypeNames.FunctionPointerName] = SemanticTokenTypes.Struct,
// in https://code.visualstudio.com/api/language-extensions/semantic-highlight-guide#standard-token-types-and-modifiers
[ClassificationTypeNames.LabelName] = "label",
}).ToImmutableDictionary();
Expand Down
33 changes: 33 additions & 0 deletions src/VisualStudio/Core/Def/ColorSchemes/VisualStudio2019.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@
<Color Name="type parameter name">
<Foreground Type="CT_RAW" Source="FF2B91AF" />
</Color>
<Color Name="array name">
</Color>
<Color Name="pointer name">
</Color>
<Color Name="function pointer name">
</Color>
<Color Name="field name">
</Color>
<Color Name="enum member name">
Expand Down Expand Up @@ -230,6 +236,12 @@
<Color Name="type parameter name">
<Foreground Type="CT_RAW" Source="FF2B91AF" />
</Color>
<Color Name="array name">
</Color>
<Color Name="pointer name">
</Color>
<Color Name="function pointer name">
</Color>
<Color Name="field name">
</Color>
<Color Name="enum member name">
Expand Down Expand Up @@ -414,6 +426,12 @@
<Color Name="type parameter name">
<Foreground Type="CT_RAW" Source="FF066555" />
</Color>
<Color Name="array name">
</Color>
<Color Name="pointer name">
</Color>
<Color Name="function pointer name">
</Color>
<Color Name="field name">
</Color>
<Color Name="enum member name">
Expand Down Expand Up @@ -595,6 +613,12 @@
<Color Name="type parameter name">
<Foreground Type="CT_RAW" Source="FFB8D7A3" />
</Color>
<Color Name="array name">
</Color>
<Color Name="pointer name">
</Color>
<Color Name="function pointer name">
</Color>
<Color Name="field name">
</Color>
<Color Name="enum member name">
Expand Down Expand Up @@ -780,6 +804,15 @@
<Color Name="type parameter name">
<Foreground Type="CT_SYSCOLOR" Source="00000008" />
</Color>
<Color Name="array name">
<Foreground Type="CT_SYSCOLOR" Source="00000008" />
</Color>
<Color Name="pointer name">
<Foreground Type="CT_SYSCOLOR" Source="00000008" />
</Color>
<Color Name="function pointer name">
<Foreground Type="CT_SYSCOLOR" Source="00000008" />
</Color>
<Color Name="field name">
<Foreground Type="CT_SYSCOLOR" Source="00000008" />
</Color>
Expand Down
Loading