Rename Flyout UI - Make everything tabbable#81319
Merged
akhera99 merged 1 commit intodotnet:mainfrom Nov 19, 2025
Merged
Conversation
jasonmalinowski
approved these changes
Nov 18, 2025
Comment on lines
+62
to
+63
| <Setter Property="IsTabStop" Value="True"/> | ||
| <Setter Property="Focusable" Value="True"/> |
Member
There was a problem hiding this comment.
Nice job doing this in the style so it applies to all buttons here.
| _viewModel.Cancel(); | ||
| break; | ||
|
|
||
| case Key.Tab: |
Member
There was a problem hiding this comment.
Bravo for also finding a way to do this directly versus us having to fight with the system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had to remove the custom tab behavior which was meant to keep the user in the rename UI. Instead, I made the tab navigation cyclical and added TabStop and Focusable to every possible entry point.