Extensions: keep round-tripped unnamed extension parameter unnamed#81311
Merged
jcouv merged 2 commits intodotnet:mainfrom Nov 19, 2025
Merged
Extensions: keep round-tripped unnamed extension parameter unnamed#81311jcouv merged 2 commits intodotnet:mainfrom
jcouv merged 2 commits intodotnet:mainfrom
Conversation
jcouv
added
Area-Compilers
Feature - Extension Everything
jjonescz
approved these changes
Nov 18, 2025
AlekseyTs
reviewed
Nov 18, 2025
| } | ||
|
|
||
| var markerMethod = ((PENamedTypeSymbol)containingSymbol.ContainingType).GetMarkerMethodSymbol(); | ||
| return markerMethod != null && object.ReferenceEquals(markerMethod, containingSymbol) && ordinal == 0; |
Contributor
AlekseyTs
reviewed
Nov 18, 2025
|
|
||
| static bool isExtensionMarkerParameter(Symbol containingSymbol, int ordinal) | ||
| { | ||
| if (containingSymbol.MetadataName != WellKnownMemberNames.ExtensionMarkerMethodName) |
Contributor
Member
Author
There was a problem hiding this comment.
The further optimization doesn't seem worthwhile. The method name check already does most of that work, and the remaining checks are built into GetMarkerMethodSymbol()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #81251
Relates to test plan #76130