Improve error recovery for incomplete attribute in a type-parameter. #81231
Conversation
- Add ValidAttributeTargets property to SyntaxContext base class - Implement ComputeValidAttributeTargets in CSharpSyntaxContext - Update IsOrContainsAccessibleAttribute to filter by AttributeTargets - Add comprehensive tests for attribute filtering scenarios Co-authored-by: CyrusNajmabadi <[email protected]>
Added lazy caching using nullable AttributeTargets field to compute the value only once per CSharpSyntaxContext instance. Co-authored-by: CyrusNajmabadi <[email protected]>
…xtensions/ContextQuery/CSharpSyntaxContext.cs
- Added WorkItem attribute to all attribute filtering tests - Added tests for all syntax node types (struct, interface, enum, delegate, record, constructor, property, field, event, parameter, type parameter, indexer) - Added tests for all target specifiers (assembly, module, type, method, field, property, event, param, return, typevar) - Simplified AttributeUsageAttribute lookup using nested property pattern - Simplified constructor argument check using collection pattern - Changed target identifier check to use SyntaxKind instead of string literals Co-authored-by: CyrusNajmabadi <[email protected]>
…ing-with-compiler
|
@dotnet/roslyn-compiler this is ready for review. |
| return false; | ||
|
|
||
| // possible attributes | ||
| if (this.CurrentToken.Kind == SyntaxKind.OpenBracketToken && this.PeekToken(1).Kind != SyntaxKind.CloseBracketToken) |
There was a problem hiding this comment.
this blocks good error recovery in the Foo<[]T> case. There isn't a good reason for this, as [] isn't a suitable start of some other construct. In all other attribute cases, running into [] is supported, just not for type params.
This simply removes that restriction, and gives consistent support for attributes here like everywhere else.
|
@RikkiGibson ptal :) |
|
@jjonescz ptal :) |
| } | ||
|
|
||
| if (this.IsCurrentTokenWhereOfConstraintClause() || | ||
| this.IsCurrentTokenPartialKeywordOfPartialMemberOrType()) |
There was a problem hiding this comment.
It's not obvious why "partial" is getting special treatment. Should we similarly care about other modifier keywords?
There was a problem hiding this comment.
partial/where refer to the special identifiers that IsTrueIdentifier returns false for if it sees that these should not actually be treated as identifiers but as contextual keywords.
They're treated specially here as they are very reasonable contextual keywords that would follow a type param being written.
| N(SyntaxKind.EndOfFileToken); | ||
| } | ||
| EOF(); | ||
| } |
There was a problem hiding this comment.
Consider testing < public or <[] public
jcouv
left a comment
jcouv
left a comment
There was a problem hiding this comment.
Done with review pass (commit 13)
…llisense-attribute-filtering-with-compiler
CyrusNajmabadi
deleted the
copilot/update-intellisense-attribute-filtering-with-compiler
branch
4 participants
Followup to #81157