-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Fix "Introduce local" generating invalid code for function pointer types #80983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
285be96
Initial plan
Copilot 690b0fc
Fix introduce local for function pointer types
Copilot d860c92
Handle normal pointer types same as function pointers
Copilot c4269b6
Update WorkItem to reference issue 80982
Copilot b81b069
Restore pointer unwrapping for custom types, keep function pointer fix
Copilot 5fdd00d
Merge remote-tracking branch 'upstream/main' into copilot/fix-introdu…
CyrusNajmabadi a25aa29
Handle pointer types
CyrusNajmabadi 7d5c78a
Handle types consistently
CyrusNajmabadi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot undo the change to pointers. If the user has
Customer*we want to still make that as if it was justCustomer. Add tests for this as well and add a 'why, not what's comment for this in the codeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in b81b069. Restored pointer unwrapping so
Customer*generates "customer". Added "why" comments explaining that normal pointers unwrap to get meaningful names while function pointers use the default. Updated test to useCustomer*→customer.