Remove MSBuild dependencies from BuidlHost deps.json #80957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
commented
Oct 30, 2025
| <PackageReference Include="System.CommandLine" Version="$(SystemCommandLineVersion)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="$(MicrosoftExtensionsLoggingConsoleVersion)" /> | ||
| <PackageReference Include="System.Text.Json" Version="$(SystemTextJsonFixedVersion)" PrivateAssets="All" Condition="'$(DotnetBuildFromSource)' != 'true'"/> | ||
| <PackageReference Include="System.Threading.Tasks.Dataflow" Version="$(SystemThreadingTasksDataflowVersion)" /> |
There was a problem hiding this comment.
Necessary for StreamJsonRpc which we eventually move away from
...Workspaces/Core/MSBuild.BuildHost/Microsoft.CodeAnalysis.Workspaces.MSBuild.BuildHost.csproj
Outdated
Show resolved
Hide resolved
dibarbet
approved these changes
Oct 30, 2025
JoeRobich
commented
Oct 30, 2025
|
|
||
| - job: Correctness_TodoCheck | ||
| pool: | ||
| vmImage: ubuntu-20.04 |
There was a problem hiding this comment.
This image no longer exists so I updated things to match what we do in dev17.10
jasonmalinowski
approved these changes
Nov 3, 2025
|
@JoeRobich We should take a look at the failing integration test legs; there are failures in the MSBuildWorkspace tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basically a backport of #75561, #71584, and #78118 .