Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -94,4 +94,32 @@ public class Sampl$$eClass()
new SymbolRenameOptions(),
CancellationToken.None);
}

[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/883")]
public async Task VerifyAnonymousTypeMemberRenameIsAllowed()
{
var markup = """
using System;

class Program
{
static void Main(string[] args)
{
var x = new { Pr$$op = 3 };
Console.WriteLine(x.Prop);
}
}
""";

using var workspace = TestWorkspace.CreateCSharp(markup, composition: EditorTestCompositions.EditorFeatures);

var documentId = workspace.Documents.Single().Id;
var document = workspace.CurrentSolution.GetRequiredDocument(documentId);
var inlineRenameService = document.GetRequiredLanguageService<IEditorInlineRenameService>();
MarkupTestFile.GetPosition(markup, out _, out int cursorPosition);
var inlineRenameInfo = await inlineRenameService.GetRenameInfoAsync(document, cursorPosition, CancellationToken.None).ConfigureAwait(false);

// Verify that rename is allowed (not error)
Assert.True(inlineRenameInfo.CanRename, "Anonymous type member should be renameable");
}
}
84 changes: 84 additions & 0 deletions src/EditorFeatures/Test2/Rename/RenameEngineTests.vb
Original file line number Diff line number Diff line change
Expand Up @@ -6960,5 +6960,89 @@ class C
result.AssertLabeledSpansAre("Complex", "C.Goo{D}(X)", RelatedLocationType.UnresolvedConflict)
End Using
End Sub

<Theory, CombinatorialData>
<WorkItem("https://github.com/dotnet/roslyn/issues/883")>
Public Sub RenameAnonymousTypePropertyInDeclaration(host As RenameTestHost)
Using result = RenameEngineResult.Create(_outputHelper,
<Workspace>
<Project Language="C#" CommonReferences="true">
<Document>
using System;

class Program
{
static void Main(string[] args)
{
var x = new
{
[|$$Prop|] = 3,
args,
};

Console.WriteLine(x.[|Prop|]);
Console.WriteLine(x.args);
}
}
</Document>
</Project>
</Workspace>, host:=host, renameTo:="Property")
End Using
End Sub

<Theory, CombinatorialData>
<WorkItem("https://github.com/dotnet/roslyn/issues/883")>
Public Sub RenameAnonymousTypePropertyInAccess(host As RenameTestHost)
Using result = RenameEngineResult.Create(_outputHelper,
<Workspace>
<Project Language="C#" CommonReferences="true">
<Document>
using System;

class Program
{
static void Main(string[] args)
{
var x = new
{
[|Prop|] = 3,
args,
};

Console.WriteLine(x.[|$$Prop|]);
Console.WriteLine(x.args);
}
}
</Document>
</Project>
</Workspace>, host:=host, renameTo:="Property")
End Using
End Sub

<Theory, CombinatorialData>
<WorkItem("https://github.com/dotnet/roslyn/issues/883")>
Public Sub RenameAnonymousTypePropertyMultipleOccurrences(host As RenameTestHost)
Using result = RenameEngineResult.Create(_outputHelper,
<Workspace>
<Project Language="C#" CommonReferences="true">
<Document>
using System;

class Program
{
static void Main(string[] args)
{
var x = new { [|$$Name|] = "Test" };
var y = new { [|Name|] = "Test2" };

Console.WriteLine(x.[|Name|]);
Console.WriteLine(y.[|Name|]);
}
}
</Document>
</Project>
</Workspace>, host:=host, renameTo:="FullName")
End Using
End Sub
End Class
End Namespace
3 changes: 0 additions & 3 deletions src/Features/Core/Portable/FeaturesResources.resx
Original file line number Diff line number Diff line change
Expand Up @@ -3039,9 +3039,6 @@ Zero-width positive lookbehind assertions are typically used at the beginning of
<data name="Please_resolve_errors_in_your_code_before_renaming_this_element" xml:space="preserve">
<value>Please resolve errors in your code before renaming this element.</value>
</data>
<data name="Renaming_anonymous_type_members_is_not_yet_supported" xml:space="preserve">
<value>Renaming anonymous type members is not yet supported.</value>
</data>
<data name="You_cannot_rename_elements_from_previous_submissions" xml:space="preserve">
<value>You cannot rename elements from previous submissions.</value>
</data>
Expand Down
3 changes: 0 additions & 3 deletions src/Features/Core/Portable/Rename/SymbolicRenameInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,6 @@ private static async Task<SymbolicRenameInfo> GetRenameInfoAsync(
return new SymbolicRenameInfo(FeaturesResources.You_cannot_rename_this_element);
}

if (symbol.Kind == SymbolKind.Property && symbol.ContainingType.IsAnonymousType)
return new SymbolicRenameInfo(FeaturesResources.Renaming_anonymous_type_members_is_not_yet_supported);

if (symbol.IsErrorType())
return new SymbolicRenameInfo(FeaturesResources.Please_resolve_errors_in_your_code_before_renaming_this_element);

Expand Down
5 changes: 0 additions & 5 deletions src/Features/Core/Portable/xlf/FeaturesResources.cs.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions src/Features/Core/Portable/xlf/FeaturesResources.de.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions src/Features/Core/Portable/xlf/FeaturesResources.es.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions src/Features/Core/Portable/xlf/FeaturesResources.fr.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions src/Features/Core/Portable/xlf/FeaturesResources.it.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions src/Features/Core/Portable/xlf/FeaturesResources.ja.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions src/Features/Core/Portable/xlf/FeaturesResources.ko.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions src/Features/Core/Portable/xlf/FeaturesResources.pl.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions src/Features/Core/Portable/xlf/FeaturesResources.pt-BR.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions src/Features/Core/Portable/xlf/FeaturesResources.ru.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions src/Features/Core/Portable/xlf/FeaturesResources.tr.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading