Skip to content

Mark CS4009 error as a "build only" error. #80698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CyrusNajmabadi merged 3 commits into from
Oct 23, 2025
Merged

Mark CS4009 error as a "build only" error. #80698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6ffadf
Mark error as build only
CyrusNajmabadi Oct 14, 2025
50635c9
Merge remote-tracking branch 'upstream/main' into buildOnlyError
CyrusNajmabadi Oct 21, 2025
02783f9
Add VB error as well
CyrusNajmabadi Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Compilers/CSharp/Portable/Errors/ErrorFacts.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,7 @@ or ErrorCode.ERR_PossibleAsyncIteratorWithoutYieldOrAwait
or ErrorCode.ERR_RefLocalAcrossAwait
or ErrorCode.ERR_DataSectionStringLiteralHashCollision
or ErrorCode.ERR_UnsupportedFeatureInRuntimeAsync
or ErrorCode.ERR_NonTaskMainCantBeAsync
// Update src\Features\CSharp\Portable\Diagnostics\LanguageServer\CSharpLspBuildOnlyDiagnostics.cs
// and TestIsBuildOnlyDiagnostic in src\Compilers\CSharp\Test\Syntax\Diagnostics\DiagnosticTest.cs
// whenever new values are added here.
Expand Down Expand Up @@ -1548,7 +1549,6 @@ or ErrorCode.ERR_AwaitInUnsafeContext
or ErrorCode.ERR_UnsafeAsyncArgType
or ErrorCode.ERR_VarargsAsync
or ErrorCode.ERR_BadAwaitArgVoidCall
or ErrorCode.ERR_NonTaskMainCantBeAsync
or ErrorCode.ERR_CantConvAsyncAnonFuncReturns
or ErrorCode.ERR_BadAwaiterPattern
or ErrorCode.ERR_BadSpecialByRefParameter
Expand Down
1 change: 1 addition & 0 deletions src/Compilers/CSharp/Test/Syntax/Diagnostics/DiagnosticTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2992,6 +2992,7 @@ public void TestIsBuildOnlyDiagnostic()
case ErrorCode.ERR_RefLocalAcrossAwait:
case ErrorCode.ERR_DataSectionStringLiteralHashCollision:
case ErrorCode.ERR_UnsupportedFeatureInRuntimeAsync:
case ErrorCode.ERR_NonTaskMainCantBeAsync:
Assert.True(isBuildOnly, $"Check failed for ErrorCode.{errorCode}");
break;

Expand Down
4 changes: 2 additions & 2 deletions src/Compilers/VisualBasic/Portable/Errors/ErrorFacts.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
Case ERRID.ERR_TypeRefResolutionError3,
ERRID.ERR_MissingRuntimeHelper,
ERRID.ERR_CannotGotoNonScopeBlocksWithClosure,
ERRID.ERR_SymbolDefinedInAssembly
ERRID.ERR_SymbolDefinedInAssembly,
ERRID.ERR_AsyncSubMain
' Update src\Features\VisualBasic\Portable\Diagnostics\LanguageServer\VisualBasicLspBuildOnlyDiagnostics.vb
' and TestIsBuildOnlyDiagnostic in src\Compilers\VisualBasic\Test\Semantic\Diagnostics\DiagnosticTests.vb
' whenever new values are added here.
Expand Down Expand Up @@ -1192,7 +1193,6 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
ERRID.ERR_BadGetAwaiterMethod1,
ERRID.ERR_RestrictedResumableType1,
ERRID.ERR_BadAwaitNothing,
ERRID.ERR_AsyncSubMain,
ERRID.ERR_PartialMethodsMustNotBeAsync1,
ERRID.ERR_InvalidAsyncIteratorModifiers,
ERRID.ERR_BadAwaitNotInAsyncMethodOrLambda,
Expand Down
3 changes: 2 additions & 1 deletion src/Compilers/VisualBasic/Test/Semantic/Diagnostics/DiagnosticTests.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,8 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.UnitTests
Case ERRID.ERR_TypeRefResolutionError3,
ERRID.ERR_MissingRuntimeHelper,
ERRID.ERR_CannotGotoNonScopeBlocksWithClosure,
ERRID.ERR_SymbolDefinedInAssembly
ERRID.ERR_SymbolDefinedInAssembly,
ERRID.ERR_AsyncSubMain
Assert.True(isBuildOnly, $"Check failed for ERRID.{err}")
Case Else
Assert.False(isBuildOnly, $"Check failed for ERRID.{err}")
Expand Down
1 change: 1 addition & 0 deletions src/Features/CSharp/Portable/Diagnostics/LanguageServer/CSharpLspBuildOnlyDiagnostics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ namespace Microsoft.CodeAnalysis.CSharp.LanguageServer;
"CS8008", // ErrorCode.ERR_ForwardedTypeConflictsWithExportedType:
"CS4007", // ErrorCode.ERR_ByRefTypeAndAwait:
"CS8178", // ErrorCode.ERR_RefReturningCallAndAwait:
"CS4009", // ErrorCode.ERR_NonTaskMainCantBeAsync:
"CS4013", // ErrorCode.ERR_SpecialByRefInLambda:
"CS1969", // ErrorCode.ERR_DynamicRequiredTypesMissing:
"CS9026", // ErrorCode.ERR_CannotBeConvertedToUtf8:
Expand Down
3 changes: 2 additions & 1 deletion ...res/VisualBasic/Portable/Diagnostics/LanguageServer/VisualBasicLspBuildOnlyDiagnostics.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.LanguageServer
"BC31091", ' ERRID.ERR_TypeRefResolutionError3,
"BC35000", ' ERRID.ERR_MissingRuntimeHelper,
"BC36597", ' ERRID.ERR_CannotGotoNonScopeBlocksWithClosure
"BC37327" ' ERRID.ERR_SymbolDefinedInAssembly
"BC37327", ' ERRID.ERR_SymbolDefinedInAssembly
"BC36934" ' ERRID.ERR_AsyncSubMain
)>
<[Shared]>
Friend NotInheritable Class VisualBasicLspBuildOnlyDiagnostics
Expand Down