Extensions: Use deterministic order for MergedNamespaceSymbol.GetMembers and GetExtensionMembers #80552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
…ers and GetExtensionMembers
jcouv
force-pushed
the
extensions-order
branch
from
49f0447 to
3026624
Compare
AlekseyTs
reviewed
Oct 3, 2025
| copy[0] = copy[last]; | ||
| copy[last] = temp; | ||
|
|
||
| return ImmutableCollectionsMarshal.AsImmutableArray(copy); |
Contributor
AlekseyTs
reviewed
Oct 3, 2025
|
|
||
| // In DEBUG, swap the first and last elements of a read-only array, yielding a new read only array. | ||
| // This helps to avoid depending on accidentally sorted arrays. | ||
| // Use more aggressive reordering with Array.Reverse(copy) for spot-checking |
Contributor
AlekseyTs
requested changes
Oct 3, 2025
Contributor
AlekseyTs
left a comment
AlekseyTs
left a comment
There was a problem hiding this comment.
I do not think we should be making these changes. We do not need to ensure this level of equivalency between DEBUG and RELEASE. For the purpose of semantic analysis, the order of members doesn't matter. Deterministic emit is the goal, and I think we are good there with respect to extensions feature. The goal behind the comment in the test plan is to confirm that whatever is causing the difference won't make problems for emit. And I think it doesn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses ordering issue tracked by #78968
Relates to test plan #76130