Update the condition used to include the CodeStyle .globalconfig by JoeRobich · Pull Request #80540 · dotnet/roslyn

JoeRobich · 2025-10-02T13:48:12Z

The logic of the original check seems to be a bit confused. It seems reasonable to include the globalconfig if the build has specifically called for it by setting either AnalysisLevelStyle or AnalysisModeStyle prior to our target running. In addition we keep the AnalysisLevel gate that will automatically add the configuration when the level is high enough.

The logic of the original check seems to be a bit confused. It seems reasonable to include the globalconfig if the build has specifically called for it by setting either AnalysisLevelStyle or AnalysisLevelMode prior to our target running. In addition we keep the AnalysisLevel gate that will automatically add the configuration when the level is high enough.

JoeRobich · 2025-10-02T14:01:09Z


-                    <!-- From .NET 11, the global config is systematically added if the file exists. Please check https://github.com/dotnet/roslyn/pull/71173 for more info. -->
-                    <ItemGroup Condition="Exists('$(_GlobalAnalyzerConfigFile_MicrosoftCodeAnalysis{language}CodeStyle)') and
-                                           ('$(AnalysisLevelStyle)' != '$(AnalysisLevel)' or '$(AnalysisModeStyle)' != '$(AnalysisMode)' or ('$(EffectiveAnalysisLevelStyle)' != '' and $([MSBuild]::VersionGreaterThanOrEquals('$(EffectiveAnalysisLevelStyle)', '11.0'))))">


As brought up in this comment #63036 (comment), the condition would exclude users who had the following configuration despite configuring AnalysisLevelStyle directly.

<AnalysisLevel>latest-all</AnalysisLevel> <AnalysisLevelStyle>latest-all</AnalysisLevelStyle>

Does this mean that we will start warning in these scenarios? Should we document this as a breaking change?

Copilot

Copilot review overview

🟡 Changes recommended

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Lite
Findings: 1

New issues introduced by this change (1)

Severity	Finding
	`src/CodeStyle/Tools/Program.cs` — The `_IncludeStyleConfiguration` property assignment has malformed XML/Condition syntax (missing…

What changed in this PR

Updates the MSBuild logic emitted by src/CodeStyle/Tools/Program.cs to decide when the CodeStyle .globalconfig should be included, aiming to make inclusion depend on explicit Style-level/mode configuration and an analysis-level threshold.

Changes:

Introduces a computed _IncludeStyleConfiguration property to centralize the “should we include the globalconfig?” decision.
Replaces the prior inline ItemGroup condition with a simpler condition based on _IncludeStyleConfiguration.

File	Description
src/CodeStyle/Tools/Program.cs	Adjusts generated MSBuild target logic for including the CodeStyle `.globalconfig`.

Suppressed comments (2)

src/CodeStyle/Tools/Program.cs:250

This line closes _IncludeStyleConfiguration with <_IncludeStyleConfiguration> instead of </_IncludeStyleConfiguration>, producing malformed XML in the generated .targets file.

                      <!-- Check whether the analysis level is high enough that we should include the analyzer configuration.
                           From .NET 12, the global config is systematically added if the file exists. Please check https://github.com/dotnet/roslyn/pull/71173 for more info. -->
                      <_IncludeStyleConfiguration Condition="'$(EffectiveAnalysisLevelStyle)' != '' and $([MSBuild]::VersionGreaterThanOrEquals('$(EffectiveAnalysisLevelStyle)', '12.0'))">true<_IncludeStyleConfiguration>

src/CodeStyle/Tools/Program.cs:268

The ItemGroup Condition has an extra trailing ) which makes the Condition expression invalid and will cause MSBuild to fail when importing the generated targets.

                    <!-- Add the analyzer configuration. -->
                    <ItemGroup Condition="Exists('$(_GlobalAnalyzerConfigFile_MicrosoftCodeAnalysis{language}CodeStyle)') and '$(_IncludeStyleConfiguration)' == 'true')">
                      <EditorConfigFiles Include="$(_GlobalAnalyzerConfigFile_MicrosoftCodeAnalysis{language}CodeStyle)" />

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Copilot review overview

🟡 Changes recommended

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Lite
Findings: 1 · 1

New issues introduced by this change (2)

Severity	Finding
	`src/CodeStyle/Tools/Program.cs` — The `ItemGroup` Condition has an extra closing `)` at the end, which makes the MSBuild condition…
	`src/CodeStyle/Tools/Program.cs` — This comment says the Style level/mode were "configured separate" from…

Issues resolved since last review (1)

Severity	Finding
	`src/CodeStyle/Tools/Program.cs` — The `_IncludeStyleConfiguration` property assignment has malformed XML/Condition syntax (missing… View resolved comment

Suppressed comments (1)

src/CodeStyle/Tools/Program.cs:251

The MSBuild property element on this line is malformed (closing tag is <_IncludeStyleConfiguration> instead of </_IncludeStyleConfiguration>), which will break MSBuild XML parsing for the generated targets file.

                      <!-- Check whether the analysis level is high enough that we should include the analyzer configuration.
                           From .NET 12, the global config is systematically added if the file exists. Please check https://github.com/dotnet/roslyn/pull/71173 for more info. -->
                      <_IncludeStyleConfiguration Condition="'$(EffectiveAnalysisLevelStyle)' != '' and $([MSBuild]::VersionGreaterThanOrEquals('$(EffectiveAnalysisLevelStyle)', '12.0'))">true<_IncludeStyleConfiguration>

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Copilot review overview

🔵 Needs a closer look

Review tier: Lite
Findings: None

Issues resolved since last review (2)

Severity	Finding
	`src/CodeStyle/Tools/Program.cs` — This comment says the Style level/mode were "configured separate" from… View resolved comment
	`src/CodeStyle/Tools/Program.cs` — The `ItemGroup` Condition has an extra closing `)` at the end, which makes the MSBuild condition… View resolved comment

Suppressed comments (2)

Previously missed (1) — in code that hasn't changed since the last review.

src/CodeStyle/Tools/Program.cs:250

This change raises the automatic-inclusion threshold from 11.0 (previous condition) to 12.0. If older SDKs still rely on this target to include the CodeStyle .globalconfig at AnalysisLevelStyle >= 11, this would be a behavior regression. Please confirm the intended SDK/version boundary and align the comment + VersionGreaterThanOrEquals check accordingly.

                      <!-- Check whether the analysis level is high enough that we should include the analyzer configuration.
                           From .NET 12, the global config is systematically added if the file exists. Please check https://github.com/dotnet/roslyn/pull/71173 for more info. -->
                      <_IncludeStyleConfiguration Condition="'$(EffectiveAnalysisLevelStyle)' != '' and $([MSBuild]::VersionGreaterThanOrEquals('$(EffectiveAnalysisLevelStyle)', '12.0'))">true<_IncludeStyleConfiguration>

src/CodeStyle/Tools/Program.cs:250

MSBuild XML is malformed here: the _IncludeStyleConfiguration element isn't closed properly (missing "/" in the end tag). This will break evaluation/parsing of the generated .targets content.

                      <_IncludeStyleConfiguration Condition="'$(EffectiveAnalysisLevelStyle)' != '' and $([MSBuild]::VersionGreaterThanOrEquals('$(EffectiveAnalysisLevelStyle)', '12.0'))">true<_IncludeStyleConfiguration>

Copilot

Copilot review overview

🟡 Changes recommended

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Lite
Findings: 1

New issues introduced by this change (1)

Severity	Finding
	`src/CodeStyle/Tools/Program.cs` — The comment here references “From .NET 12…”, but the gating logic is based on…

+                      <!-- Check whether the analysis level is high enough that we should include the analyzer configuration.
+                           From .NET 12, the global config is systematically added if the file exists. Please check https://github.com/dotnet/roslyn/pull/71173 for more info. -->
+                      <_IncludeStyleConfiguration Condition="'$(EffectiveAnalysisLevelStyle)' != '' and $([MSBuild]::VersionGreaterThanOrEquals('$(EffectiveAnalysisLevelStyle)', '12.0'))">true</_IncludeStyleConfiguration>


JoeRobich requested a review from a team as a code owner October 2, 2025 13:48

github-actions Bot added the Area-IDE label Oct 2, 2025

dotnet-policy-service Bot added the VSCode label Oct 2, 2025

JoeRobich commented Oct 2, 2025

View reviewed changes

build-analysis Bot mentioned this pull request Oct 2, 2025

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

3 tasks

dibarbet approved these changes Oct 2, 2025

View reviewed changes

JoeRobich commented Aug 31, 2026

View reviewed changes

Comment thread src/CodeStyle/Tools/Program.cs Outdated

Apply suggestion from @JoeRobich

3a42c06

Copilot AI lite review requested due to automatic review settings August 31, 2026 17:24

Copilot started reviewing on behalf of JoeRobich August 31, 2026 17:24 View session

Copilot AI reviewed Aug 31, 2026

View reviewed changes

Comment thread src/CodeStyle/Tools/Program.cs Outdated

Potential fix for pull request finding

0506322

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings August 31, 2026 17:29

akhera99 approved these changes Aug 31, 2026

View reviewed changes

Copilot started reviewing on behalf of JoeRobich August 31, 2026 17:29 View session

Copilot AI reviewed Aug 31, 2026

View reviewed changes

Comment thread src/CodeStyle/Tools/Program.cs Outdated

Comment thread src/CodeStyle/Tools/Program.cs

Potential fix for pull request finding

b799157

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings August 31, 2026 17:35

Copilot started reviewing on behalf of JoeRobich August 31, 2026 17:36 View session

Copilot AI reviewed Aug 31, 2026

View reviewed changes

build-analysis Bot mentioned this pull request Aug 31, 2026

NuGet failing with Response status code does not indicate success: 503 (Service Unavailable) dotnet/arcade#11723

Open

5 tasks

JoeRobich commented Aug 31, 2026

View reviewed changes

Comment thread src/CodeStyle/Tools/Program.cs Outdated

Apply suggestion from @JoeRobich

b812f96

Copilot AI review requested due to automatic review settings August 31, 2026 22:53

Copilot started reviewing on behalf of JoeRobich August 31, 2026 22:53 View session

Copilot AI reviewed Aug 31, 2026

View reviewed changes

dibarbet approved these changes Aug 31, 2026

View reviewed changes

JoeRobich merged commit 1f74195 into main Sep 2, 2026
23 checks passed

dotnet-policy-service Bot added this to the Next milestone Sep 2, 2026

This was referenced Sep 2, 2026

[release/11.0.1xx] Source code updates from dotnet/roslyn dotnet/dotnet#8986

Merged

[main] Source code updates from dotnet/roslyn dotnet/dotnet#8994

Merged

dotnet-bot mentioned this pull request Sep 3, 2026

[Automated] PRs inserted in VS build main-12202.446 #85143

Closed

dibarbet mentioned this pull request Sep 4, 2026

Update roslyn to 5.12.0-1.26453.19 dotnet/vscode-csharp#9731

Merged

jjonescz mentioned this pull request Sep 7, 2026

[main] Source code updates from dotnet/dotnet dotnet/sdk#56126

Merged

Navigation Menu

Uh oh!

Update the condition used to include the CodeStyle .globalconfig - #80540

Update the condition used to include the CodeStyle .globalconfig#80540
JoeRobich merged 5 commits into
mainfrom
dev/jorobich/update-codestyle-condition

JoeRobich commented Oct 2, 2025 •

edited

Loading

Uh oh!

JoeRobich Oct 2, 2025 •

edited

Loading

Uh oh!

333fred Aug 31, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

JoeRobich commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoeRobich Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

333fred Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JoeRobich commented Oct 2, 2025 •

edited

Loading

JoeRobich Oct 2, 2025 •

edited

Loading