Invoke Created action from HotReloadException constructor #79790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
force-pushed
the
HRECreated
branch
2 times, most recently
from
8cd8591 to
4b4910b
Compare
tmat
force-pushed
the
HRECreated
branch
2 times, most recently
from
b718dca to
cc0f523
Compare
|
@dotnet/roslyn-compiler ptal |
AlekseyTs
reviewed
Sep 16, 2025
src/Compilers/CSharp/Portable/Emitter/EditAndContinue/PEDeltaAssemblyBuilder.cs
Show resolved
Hide resolved
|
Done with review pass (commit 2) #Closed |
jcouv
reviewed
Sep 22, 2025
| new SynthesizedHotReloadExceptionConstructorSymbol(this, stringType, intType), | ||
| new SynthesizedFieldSymbol(this, intType, CodeFieldName, DeclarationModifiers.Public, isReadOnly: true, isStatic: false) | ||
| new SynthesizedFieldSymbol(this, intType, CodeFieldName, DeclarationModifiers.Public, isReadOnly: true, isStatic: false), | ||
| new SynthesizedFieldSymbol(this, actionOfTType.Construct(exceptionType), CreatedActionFieldName, DeclarationModifiers.Private, isReadOnly: false, isStatic: true) |
There was a problem hiding this comment.
actionOfTType.Construct(exceptionType), CreatedActionFieldName
Is it intentional that we don't care about constraints (in a scenario with a custom Action type)? We generally check constraints whenever we construct symbols, but we may have an exception for types that are expected to be defined in the BCL (in System namespace) where we may make certain assumptions. I'm not sure
jcouv
reviewed
Sep 22, 2025
...pilers/CSharp/Portable/Symbols/Synthesized/SynthesizedHotReloadExceptionConstructorSymbol.cs
Show resolved
Hide resolved
jcouv
reviewed
Sep 22, 2025
...pilers/CSharp/Portable/Symbols/Synthesized/SynthesizedHotReloadExceptionConstructorSymbol.cs
Show resolved
Hide resolved
jcouv
reviewed
Sep 22, 2025
|
/backport to release/dev18.0 |
|
Started backporting to release/dev18.0: https://github.com/dotnet/roslyn/actions/runs/18015545762 |
Merged
2 tasks
phil-allen-msft
added a commit
that referenced
this pull request
Sep 30, 2025
…ception constructor (#80463) Backport of #79790 to release/dev18.0 /cc @tmat ## Customer Impact ## Regression - [ ] Yes - [x] No [If yes, specify when the regression was introduced. Provide the PR or commit if known.] ## Testing [How was the fix verified? How was the issue missed previously? What tests were added?] ## Risk [High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emits field
private static Action<HotReloadException> Createdto synthesizedHotReloadExceptiontype and addsCreated?.Invoke(this)to its constructor.This allows Hot Reload agent injected in the application process to hook up a handler that notifies the host when a runtime rude edit occurs.
The host may decide to restart the application at that point (
HotReloadAutoRestartsetting is on).Contributes to dotnet/sdk#48515.