Skip to content

Allow captured primary constructor parameters to be still used in base-list #79512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CyrusNajmabadi merged 1 commit into from
Jul 22, 2025
Merged

Allow captured primary constructor parameters to be still used in base-list #79512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/EditorFeatures/Test2/IntelliSense/CSharpCompletionCommandHandlerTests.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11931,6 +11931,27 @@ public class C(int x) : Base(x)
End Using
End Function

<WpfFact, WorkItem("https://github.com/dotnet/roslyn/issues/78917")>
Public Async Function FilterPrimaryConstructorParameters_AllowInBaseTypeWhenCapturedAsMember() As Task
Using state = TestStateFactory.CreateCSharpTestState(
<Document><![CDATA[
public sealed class Derived(
string value)
: Base($"{val$$}")
{
public string Value { get; } = value;
}

public abstract class Base(string value);
]]>
</Document>,
languageVersion:=LanguageVersion.CSharp12)

state.SendInvokeCompletionList()
Await state.AssertCompletionItemsContain("value", displayTextSuffix:="")
End Using
End Function

<WpfFact, Trait(Traits.Feature, Traits.Features.Completion)>
Public Async Function TestItemsSorted() As Task
Using state = TestStateFactory.CreateCSharpTestState(
Expand Down
7 changes: 6 additions & 1 deletion src/Workspaces/CSharp/Portable/Recommendations/CSharpRecommendationServiceRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ static bool IsCapturedPrimaryConstructorParameter(
CancellationToken cancellationToken)
{
// Fine to offer primary constructor parameters in field/property initializers
var initializer = context.TargetToken.GetAncestors<EqualsValueClauseSyntax>().FirstOrDefault();
var initializer = context.TargetToken.GetAncestor<EqualsValueClauseSyntax>();
if (initializer is
{
Parent: PropertyDeclarationSyntax or
Expand All @@ -453,6 +453,11 @@ static bool IsCapturedPrimaryConstructorParameter(
return false;
}

// Also fine to offer primary constructor parameters in the base type list of that type.
var baseTypeSyntax = context.TargetToken.GetAncestor<PrimaryConstructorBaseTypeSyntax>();
if (baseTypeSyntax != null)
return false;

// We're not in an initializer. Filter out this primary constructor parameter if it's already been
// captured by an existing field or property initializer.

Expand Down
Loading