Skip to content

Remove obsolete code from Razor EA #79220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidwengier merged 1 commit into from
Jul 2, 2025
Merged

Remove obsolete code from Razor EA #79220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/Tools/ExternalAccess/Razor/Features/Cohost/RazorCohostRequestContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ internal readonly struct RazorCohostRequestContext(RequestContext context)
{
internal string Method => context.Method;

[Obsolete("Use DocumentUri instead")]
internal Uri? Uri => context.TextDocument?.GetURI().GetRequiredParsedUri();
internal DocumentUri? DocumentUri => context.TextDocument?.GetURI();
/// <inheritdoc cref="RequestContext.Workspace"/>
internal Workspace? Workspace => context.Workspace;
Expand Down
47 changes: 0 additions & 47 deletions src/Tools/ExternalAccess/Razor/Features/RazorCSharpFormattingInteractionService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,25 +23,6 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.Razor
/// </summary>
internal static class RazorCSharpFormattingInteractionService
{
[Obsolete("This overload is for binary compat only. Use GetFormattingChangesAsync with all parameters instead.")]
public static Task<ImmutableArray<TextChange>> GetFormattingChangesAsync(
Document document,
char typedChar,
int position,
RazorIndentationOptions indentationOptions,
RazorAutoFormattingOptions autoFormattingOptions,
FormattingOptions.IndentStyle indentStyle,
CancellationToken cancellationToken)
=> GetFormattingChangesAsync(
document,
typedChar,
position,
indentationOptions,
autoFormattingOptions,
indentStyle,
csharpSyntaxFormattingOptionsOverride: null,
cancellationToken);

/// <summary>
/// Returns the text changes necessary to format the document after the user enters a
/// character. The position provided is the position of the caret in the document after
Expand Down Expand Up @@ -76,21 +57,6 @@ public static async Task<ImmutableArray<TextChange>> GetFormattingChangesAsync(
return formattingService.GetFormattingChangesOnTypedCharacter(documentSyntax, position, roslynIndentationOptions, cancellationToken);
}

[Obsolete("This overload is for binary compat only. Use GetFormattingChangesAsync with all parameters instead.")]
public static IList<TextChange> GetFormattedTextChanges(
HostWorkspaceServices services,
SyntaxNode root,
TextSpan span,
RazorIndentationOptions indentationOptions,
CancellationToken cancellationToken)
=> GetFormattedTextChanges(
services,
root,
span,
indentationOptions,
csharpSyntaxFormattingOptionsOverride: null,
cancellationToken);

public static IList<TextChange> GetFormattedTextChanges(
HostWorkspaceServices services,
SyntaxNode root,
Expand All @@ -103,19 +69,6 @@ public static IList<TextChange> GetFormattedTextChanges(
return Formatter.GetFormattedTextChanges(root, span, services.SolutionServices, GetFormattingOptions(services.SolutionServices, indentationOptions, csharpSyntaxFormattingOptionsOverride), cancellationToken);
}

[Obsolete("This overload is for binary compat only. Use GetFormattingChangesAsync with all parameters instead.")]
public static SyntaxNode Format(
HostWorkspaceServices services,
SyntaxNode root,
RazorIndentationOptions indentationOptions,
CancellationToken cancellationToken)
=> Format(
services,
root,
indentationOptions,
csharpSyntaxFormattingOptionsOverride: null,
cancellationToken);

public static SyntaxNode Format(
HostWorkspaceServices services,
SyntaxNode root,
Expand Down
6 changes: 0 additions & 6 deletions src/Tools/ExternalAccess/Razor/Features/WorkspaceExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,6 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.Razor.Features;

internal static class WorkspaceExtensions
{
[Obsolete("Use GetTextDocumentAsync with DocumentUri instead.")]
public static ValueTask<TextDocument?> GetTextDocumentAsync(this Workspace workspace, Uri uri, CancellationToken cancellationToken)
{
return GetTextDocumentAsync(workspace, new DocumentUri(uri), cancellationToken);
}

public static ValueTask<TextDocument?> GetTextDocumentAsync(this Workspace workspace, DocumentUri uri, CancellationToken cancellationToken)
{
var identifier = new TextDocumentIdentifier() { DocumentUri = uri };
Expand Down
Loading