Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/Compilers/.editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ dotnet_diagnostic.RS0100.severity = none
# RS0102: Braces must not have blank lines between them
dotnet_diagnostic.RS0102.severity = none

# IDE0051: Unused member
dotnet_diagnostic.IDE0051.severity = none

# IDE0170: Prefer extended property pattern
dotnet_diagnostic.IDE0170.severity = suggestion

Expand Down
5 changes: 3 additions & 2 deletions src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6660,7 +6660,7 @@ public void ResponseFileSplitting()
}

[ConditionalFact(typeof(WindowsOnly))]
private void SourceFileQuoting()
public void SourceFileQuoting()
{
string[] responseFile = new string[] {
@"d:\\""abc def""\baz.cs ab""c d""e.cs",
Expand Down Expand Up @@ -12060,7 +12060,6 @@ at Microsoft.CodeAnalysis.Diagnostics.AnalyzerExecutor.CreateDisablingMessage(Di

Assert.Equal(0, result.ExitCode);
}
#endif

private static ImmutableArray<byte> CreateCSharpAnalyzerNetStandard13(string analyzerAssemblyName)
{
Expand Down Expand Up @@ -12221,6 +12220,8 @@ public override void Initialize(AnalysisContext context)
return analyzerImage;
}

#endif

[WorkItem(406649, "https://devdiv.visualstudio.com/DevDiv/_workitems?id=484417")]
[ConditionalFact(typeof(WindowsDesktopOnly), typeof(IsEnglishLocal), Reason = "https://github.com/dotnet/roslyn/issues/30321")]
public void MicrosoftDiaSymReaderNativeAltLoadPath()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -155,37 +155,6 @@ private void RepeatTest(
RepeatTest((e, i, it) => testCode(e, i), iters);
}

private void VerifyModifiedEnumerator(
IEnumerator<T> enumerator,
object expectedCurrent,
bool expectCurrentThrow,
bool atEnd)
{
if (expectCurrentThrow)
{
Assert.Throws<InvalidOperationException>(
() => enumerator.Current);
}
else
{
object? current = enumerator.Current;
for (int i = 0; i < 3; i++)
{
Assert.Equal(expectedCurrent, current);
current = enumerator.Current;
}
}

Assert.Throws<InvalidOperationException>(
() => enumerator.MoveNext());

if (!!ResetImplemented)
{
Assert.Throws<InvalidOperationException>(
() => enumerator.Reset());
}
}

private void VerifyEnumerator(
IEnumerator<T> enumerator,
T[] expectedItems)
Expand Down
5 changes: 0 additions & 5 deletions src/Compilers/Core/RebuildTest/RebuildCommandLineTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,6 @@ private void AddSourceFile(string filePath, string content)
FilePathToStreamMap.Add(Path.Combine(BuildPaths.WorkingDirectory, filePath), new TestableFile(content));
}

private void AddReference(string filePath, byte[] imageBytes)
{
FilePathToStreamMap.Add(Path.Combine(BuildPaths.SdkDirectory!, filePath), new TestableFile(imageBytes));
}

private void AddOutputFile(ref string? filePath)
{
if (filePath is object)
Expand Down
18 changes: 0 additions & 18 deletions src/Compilers/Test/Core/Compilation/OperationTreeVerifier.cs
Original file line number Diff line number Diff line change
Expand Up @@ -175,19 +175,6 @@ private static string GetSnippetFromSyntax(SyntaxNode syntax)
return $"'{prefix} ... {suffix}'";
}

private static bool ShouldLogType(IOperation operation)
{
var operationKind = (int)operation.Kind;

// Expressions
if (operationKind >= 0x100 && operationKind < 0x400)
{
return true;
}

return false;
}

protected void LogString(string str)
{
if (_pendingIndent)
Expand Down Expand Up @@ -409,11 +396,6 @@ private void VisitArray<T>(ImmutableArray<T> list, string header, bool logElemen
VisitArrayCommon(list, header, logElementCount, logNullForDefault, o => Visit(o));
}

private void VisitArray(ImmutableArray<ISymbol> list, string header, bool logElementCount, bool logNullForDefault = false)
{
VisitArrayCommon(list, header, logElementCount, logNullForDefault, VisitSymbolArrayElement);
}

private void VisitArray(ImmutableArray<string> list, string header, bool logElementCount, bool logNullForDefault = false)
{
VisitArrayCommon(list, header, logElementCount, logNullForDefault, VisitStringArrayElement);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -519,12 +519,6 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Symbols
Return _lazyNetModuleAttributesBag
End Function

Private Function GetNetModuleAttributes() As ImmutableArray(Of VisualBasicAttributeData)
Dim attributesBag = Me.GetNetModuleAttributesBag()
Debug.Assert(attributesBag.IsSealed)
Return attributesBag.Attributes
End Function

Friend Function GetNetModuleDecodedWellKnownAttributeData() As CommonAssemblyWellKnownAttributeData
Dim attributesBag = Me.GetNetModuleAttributesBag()
Debug.Assert(attributesBag.IsSealed)
Expand Down