Skip to content

Remove workarounds for bugs that have been fixed #78779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonmalinowski merged 1 commit into from
Jun 2, 2025
Merged

Remove workarounds for bugs that have been fixed #78779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions src/EditorFeatures/TestUtilities/TestExtensionErrorHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,27 +27,6 @@ public TestExtensionErrorHandler()

public void HandleError(object sender, Exception exception)
{
// Work around bug that is fixed in https://devdiv.visualstudio.com/DevDiv/_git/VS-Platform/pullrequest/209513
if (exception is NullReferenceException &&
exception.StackTrace.Contains("SpanTrackingWpfToolTipPresenter"))
{
return;
}

// Work around for https://github.com/dotnet/roslyn/issues/42982
if (exception is NullReferenceException &&
exception.StackTrace.Contains("Microsoft.CodeAnalysis.Completion.Providers.AbstractEmbeddedLanguageCompletionProvider.GetLanguageProviders"))
{
return;
}

// Work around for https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1091056
if (exception is InvalidOperationException &&
exception.StackTrace.Contains("Microsoft.VisualStudio.Language.Intellisense.AsyncCompletion.Implementation.CompletionTelemetryHost"))
{
return;
}

// This exception is unexpected and as such we want the containing test case to
// fail. Unfortuntately throwing an exception here is not going to help because
// the editor is going to catch and swallow it. Store it here and wait for the
Expand Down
6 changes: 0 additions & 6 deletions src/VisualStudio/IntegrationTest/TestSetup/TestExtensionErrorHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,6 @@ public TestExtensionErrorHandler()

public void HandleError(object sender, Exception exception)
{
if (exception.Message == "RemotePartyTerminated" && new System.Diagnostics.StackTrace().ToString().Contains("CodeLens") ||
exception.Message == "Cannot access a disposed object.\r\nObject name: 'CodeLensHubClient'.")
{
return;
}

FatalError.ReportAndPropagate(exception);
TestTraceListener.Instance.AddException(exception);
}
Expand Down
Loading