Optimize work done in ProjectCodeModelFactory #78369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Change the ABWQ to hold WorkspaceChangeEventArgs. By doing this, we don't need to calculate the solution/project changes before placing items in the queue. 2) Ensure _visualStudioWorkspace.GetFilePath is done from a bg thread
ghost
added
Area-IDE
untriaged
| var stopwatch = SharedStopwatch.StartNew(); | ||
| foreach (var documentId in documentIds) | ||
| // Fire off the code model events while on the main thread | ||
| await FireEventsForChangedDocumentsAsync(projectCodeModelAndFileNames, cancellationToken).ConfigureAwait(false); |
Member
There was a problem hiding this comment.
nit: since this method is async, you can move the STMTA into it.
Contributor
Author
There was a problem hiding this comment.
I actually kind of preferred it in the outer method, as that's what's done for the background thread assurance. This way, if more work needs to be done on the main thread, it can just be called from the same section in ProcessNextWorkspaceChangeEventBatchAsync.
src/VisualStudio/Core/Impl/CodeModel/ProjectCodeModelFactory.cs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| nextInputCheckElapsedMs = elapsedMs + 1; | ||
| } |
Member
There was a problem hiding this comment.
i assume this logic was the same as before.
Contributor
Author
There was a problem hiding this comment.
This logic changed, as IsInputPending showed up in the profiles
CyrusNajmabadi
approved these changes
Apr 29, 2025
3 tasks
This was referenced May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the ABWQ to hold WorkspaceChangeEventArgs. By doing this, we don't need to calculate the solution/project changes before placing items in the queue.
Ensure _visualStudioWorkspace.GetFilePath is done from a bg thread
Test insertion PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/631967
*** old CPU under ProjectCodeModelFactory ***
*** old allocs under ProjectCodeModelFactory ***
*** new CPU under ProjectCodeModelFactory ***
*** new allocs under ProjectCodeModelFactory ***
