Skip to content

Edit & Continue support for field access in auto-properties #78289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DustinCampbell merged 5 commits into from
Apr 30, 2025
Merged

Edit & Continue support for field access in auto-properties #78289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ec80ec
Ensure EnC tests use "preview" lang version for C# and "latest" for VB
DustinCampbell Apr 23, 2025
dbb1e92
Add top-level editing tests for EnC on auto-props with field keyword
DustinCampbell Apr 23, 2025
11d4e3d
Allow setters when checking for auto-properties
DustinCampbell Apr 23, 2025
2bbb5b5
Add a couple active statement tests for C# field keyword in auto-props
DustinCampbell Apr 23, 2025
52ab133
Add E&C tests at the compiler layer for auto-props with field keyword
DustinCampbell Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
277 changes: 266 additions & 11 deletions src/Compilers/CSharp/Test/Emit2/Emit/EditAndContinue/EditAndContinueTests.cs
View file
Open in desktop

Large diffs are not rendered by default.

46 changes: 46 additions & 0 deletions src/Features/CSharpTest/EditAndContinue/ActiveStatementTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2199,6 +2199,52 @@ class C
capabilities: EditAndContinueCapabilities.AddMethodToExistingType);
}

[Fact]
public void Property_Update_ExpressionBodyToAutoProp_FieldAccess()
{
var src1 = @"
class C
{
public int P => <AS:0>1</AS:0>;
}
";
var src2 = @"
class C
{
public int P => <AS:0>field</AS:0>;
}
";
var edits = GetTopEdits(src1, src2);
var active = GetActiveStatements(src1, src2);

edits.VerifySemanticDiagnostics(
active,
capabilities: EditAndContinueCapabilities.AddInstanceFieldToExistingType);
}

[Fact]
public void Property_Update_Accessor_ExpressionBodyToAutoProp_FieldAccess()
{
var src1 = @"
class C
{
public int P { get => <AS:0>1</AS:0>; }
}
";
var src2 = @"
class C
{
public int P { get => <AS:0>field</AS:0>; }
}
";
var edits = GetTopEdits(src1, src2);
var active = GetActiveStatements(src1, src2);

edits.VerifySemanticDiagnostics(
active,
capabilities: EditAndContinueCapabilities.AddInstanceFieldToExistingType);
}

[Fact]
public void Property_Auto_Record_ReplacingNonPrimaryWithPrimary_Getter()
{
Expand Down
1 change: 1 addition & 0 deletions src/Features/CSharpTest/EditAndContinue/Helpers/CSharpEditAndContinueTestVerifier.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ internal sealed class CSharpEditAndContinueTestVerifier(Action<SyntaxNode>? faul
public override string ProjectFileExtension => ".csproj";
public override TreeComparer<SyntaxNode> TopSyntaxComparer => SyntaxComparer.TopLevel;
public override string? TryGetResource(string keyword) => EditingTestBase.TryGetResource(keyword);
public override ParseOptions ParseOptions => CSharpParseOptions.Default.WithLanguageVersion(LanguageVersion.Preview);

public override ImmutableArray<SyntaxNode> GetDeclarators(ISymbol method)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Features/CSharpTest/EditAndContinue/Helpers/EditingTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ internal static string GetDocumentFilePath(int documentIndex)
private static SyntaxTree ParseSource(string markedSource, int documentIndex = 0)
=> SyntaxFactory.ParseSyntaxTree(
SourceMarkers.Clear(markedSource),
CSharpParseOptions.Default.WithLanguageVersion(LanguageVersion.CSharp12),
CSharpParseOptions.Default.WithLanguageVersion(LanguageVersion.Preview),
path: GetDocumentFilePath(documentIndex));

internal static EditScriptDescription GetTopEdits(string methodBody1, string methodBody2, MethodKind kind)
Expand Down
Loading