Adding new EA api at 'Features' layer for unit testing ot use #78175
Conversation
ghost
added
Area-IDE
untriaged
| { | ||
| Task<ImmutableArray<ReferenceMethodDescriptor>?> FindReferenceMethodsAsync( | ||
| Guid projectGuid, string filePath, TextSpan span, DocumentId? sourceGeneratedDocumentId, CancellationToken cancellationToken); | ||
| } |
There was a problem hiding this comment.
nothing you need to worry about @shyamnamboodiripad This just gives us a strong api signature between this code here and the impl on the vs side.
| internal interface IUnitTestingFeaturesReferencesServiceCallback | ||
| { | ||
| Task<TResult> InvokeAsync<TResult>(string targetName, IReadOnlyList<object?> arguments, CancellationToken cancellationToken); | ||
| } |
There was a problem hiding this comment.
@shyam you'll provide an impl of this on your side. it will be implemented as:
class YourImpl(
IAsyncCodeLensDataPointProvider provider,
ICodeLensCallbackService callbackService) : IUnitTestingFeaturesReferencesServiceCallback
{
public Task<TResult> InvokeAsync<TResult>(string targetName, IReadOnlyList<object?> arguments, CancellationToken cancellationToken) => callbackService.InvokeAsync(targetName, arguments, cancellationToken);
}
src/Features/Core/Portable/ExternalAccess/UnitTesting/UnitTestingFeaturesReferencesService.cs
Show resolved
Hide resolved
| TextSpan span, | ||
| DocumentId? sourceGeneratedDocumentId, | ||
| IUnitTestingFeaturesReferencesServiceCallback callback, | ||
| CancellationToken cancellationToken) |
There was a problem hiding this comment.
this api is much lower than the prior Editor level api. So it doesn't talk about vs codelens concepts. It just talks about data, and just passes in an abstraction for the call to be made back to VS through the 'callback' parameter which hides all the codelens stuff as well.
|
@dibarbet ptal |
|
|
||
| internal static class CodeLensHelpers | ||
| { | ||
| public static DocumentId? GetSourceGeneratorDocumentId(IDictionary<object, object> descriptorProperties) |
There was a problem hiding this comment.
moved from later code. used by us, and then also exposed through EA for UnitTesting to use.
4 participants
Supplants the existing EditorFEatures api
UnitTestingReferencesService. Once we get unit testing onto this new api, we can remove that old api and remove their dependency on EditorFEatures.