Skip to content

Conversation

@CyrusNajmabadi
Copy link
Member

This oddly got moved up to the LSP layer. There was only one line in it that seems to be causing this, and it was trivial to address. So i moved it back, as this is the more appropriate layer (it is feature-level, without any LSP dependencies).

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner April 12, 2025 17:56
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 12, 2025
@CyrusNajmabadi
Copy link
Member Author

@JoeRobich @dibarbet @ToddGrun @tmat ptal.

Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit e3f3ac9 into dotnet:main Apr 13, 2025
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the moveServiceDown branch April 13, 2025 20:39
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 13, 2025
CyrusNajmabadi added a commit to CyrusNajmabadi/roslyn that referenced this pull request May 7, 2025
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants