Skip to content

Conversation

@jasonmalinowski
Copy link
Member

This shouldn't be needed anymore, and prevents some design time build breaks if NuGet restore wasn't able to get this package.

Fixes #74923

This shouldn't be needed anymore, and prevents some design time build
breaks if NuGet restore wasn't able to get this package.

Fixes dotnet#74923
@jasonmalinowski jasonmalinowski requested a review from a team as a code owner March 7, 2025 20:25
@ghost ghost added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 7, 2025
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jasonmalinowski
Copy link
Member Author

@jaredpar Is the fact this built sufficient to know it's all good, or do I need to do some more testing?

@jasonmalinowski jasonmalinowski self-assigned this Mar 7, 2025
@jaredpar
Copy link
Member

jaredpar commented Mar 9, 2025

Is the fact this built sufficient to know it's all good, or do I need to do some more testing?

Believe that @tmat originally added that so he may know best.

@tmat
Copy link
Member

tmat commented Mar 10, 2025

@jaredpar I don't recall this workaround. Added here: bd43f6d

#74923

@jaredpar
Copy link
Member

Hmm ... I must have gotten that work around from someone else then. Looked at the issue and we should be safe to revert.

@jasonmalinowski jasonmalinowski merged commit 8458e61 into dotnet:main Mar 10, 2025
28 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 10, 2025
@jasonmalinowski jasonmalinowski deleted the remove-wpf-workaround branch March 10, 2025 23:29
@jjonescz jjonescz modified the milestones: Next, 17.14 P3 Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revert WPF work around when we merge RC1 SDK

5 participants